-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resizeable rule preview #3000
Resizeable rule preview #3000
Conversation
Documentation previews: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left one tiny suggestion for you to consider
Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank for documenting this!
* Update screenshot * Add text, icon image * Update docs/detections/rules-ui-create.asciidoc Co-authored-by: Benjamin Ironside Goldstein <[email protected]> --------- Co-authored-by: Benjamin Ironside Goldstein <[email protected]> (cherry picked from commit 914e2eb)
* Update screenshot * Add text, icon image * Update docs/detections/rules-ui-create.asciidoc Co-authored-by: Benjamin Ironside Goldstein <[email protected]> --------- Co-authored-by: Benjamin Ironside Goldstein <[email protected]> (cherry picked from commit 914e2eb) Co-authored-by: Joe Peeples <[email protected]>
Resolves #2897.
Preview: Create a detection rule | Preview your rule (optional)