Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resizeable rule preview #3000

Merged
merged 6 commits into from
Mar 10, 2023
Merged

Resizeable rule preview #3000

merged 6 commits into from
Mar 10, 2023

Conversation

joepeeples
Copy link
Contributor

@joepeeples joepeeples commented Feb 16, 2023

@github-actions
Copy link

Documentation previews:

@joepeeples joepeeples marked this pull request as ready for review February 16, 2023 20:37
Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left one tiny suggestion for you to consider

docs/detections/rules-ui-create.asciidoc Outdated Show resolved Hide resolved
@joepeeples joepeeples requested a review from e40pud February 24, 2023 21:13
Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@e40pud e40pud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for documenting this!

@joepeeples joepeeples merged commit 914e2eb into main Mar 10, 2023
mergify bot pushed a commit that referenced this pull request Mar 10, 2023
* Update screenshot

* Add text, icon image

* Update docs/detections/rules-ui-create.asciidoc

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>

---------

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
(cherry picked from commit 914e2eb)
@joepeeples joepeeples deleted the 2897-resizable-rule-preview branch March 10, 2023 16:28
joepeeples added a commit that referenced this pull request Mar 10, 2023
* Update screenshot

* Add text, icon image

* Update docs/detections/rules-ui-create.asciidoc

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>

---------

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
(cherry picked from commit 914e2eb)

Co-authored-by: Joe Peeples <[email protected]>
@joepeeples joepeeples mentioned this pull request Mar 22, 2023
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resizeable rule preview
5 participants