Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Tines connector #2769

Merged
merged 5 commits into from
Jan 9, 2023
Merged

[DOCS] Tines connector #2769

merged 5 commits into from
Jan 9, 2023

Conversation

nastasha-solomon
Copy link
Contributor

@nastasha-solomon nastasha-solomon commented Dec 5, 2022 •
edited
Loading

Addresses #2689.

Preview:

@nastasha-solomon nastasha-solomon self-assigned this Dec 5, 2022
@github-actions
Copy link

github-actions bot commented Dec 5, 2022

Documentation previews:

@nastasha-solomon nastasha-solomon requested a review from a team December 6, 2022 19:34
@nastasha-solomon nastasha-solomon marked this pull request as ready for review December 6, 2022 19:35
benironside
benironside approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nastasha-solomon nastasha-solomon added the readyforQA PRs that are ready for QA review. label Jan 4, 2023
@ghost
Copy link

ghost commented Jan 5, 2023

Hi @nastasha-solomon ,

We tested the linked docs and found that the doc is correctly updated as per the latest UI. So we are good to go ahead and merge the changes.

Marking this ticket as 'QA validated'.

Thanks!

@ghost ghost added QA:Validated Issue has been Validated by QA Team and removed readyforQA PRs that are ready for QA review. labels Jan 5, 2023
jmikell821
jmikell821 approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image LGTM, thanks!

@nastasha-solomon nastasha-solomon merged commit 410c2e6 into main Jan 9, 2023
@nastasha-solomon nastasha-solomon deleted the issue-2689-tines branch January 9, 2023 20:42
mergify bot pushed a commit that referenced this pull request Jan 9, 2023
@nastasha-solomon @mergify
[DOCS] Tines connector (#2769)
175e0e3 
(cherry picked from commit 410c2e6)
@mergify mergify bot mentioned this pull request Jan 9, 2023
Merged
nastasha-solomon added a commit that referenced this pull request Jan 9, 2023
@mergify @nastasha-solomon
[8.6] [DOCS] Tines connector (backport #2769) (#2828)
d0f365a 
Co-authored-by: nastasha-solomon <[email protected]>
@nastasha-solomon nastasha-solomon mentioned this pull request Jan 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benironside benironside benironside approved these changes

@jmikell821 jmikell821 jmikell821 approved these changes

Assignees

@nastasha-solomon nastasha-solomon

Labels
QA:Validated Issue has been Validated by QA Team Team: Docs Team: Threat Hunting Formerly Data Visibility v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nastasha-solomon @jmikell821 @benironside