-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Value list exceptions for all rule types #2562
Conversation
Documentation previews: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small nits. LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Janeen Mikell-Straughn <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 👍
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: Marshall Main <[email protected]>
* Update detections-ui-exceptions.asciidoc * Smol edits * Apply suggestions from Janeen's review Co-authored-by: Janeen Mikell-Straughn <[email protected]> * Apply suggestions from Marshall's review Co-authored-by: Marshall Main <[email protected]> Co-authored-by: Janeen Mikell-Straughn <[email protected]> Co-authored-by: Marshall Main <[email protected]> (cherry picked from commit c85062b)
* Update detections-ui-exceptions.asciidoc * Smol edits * Apply suggestions from Janeen's review Co-authored-by: Janeen Mikell-Straughn <[email protected]> * Apply suggestions from Marshall's review Co-authored-by: Marshall Main <[email protected]> Co-authored-by: Janeen Mikell-Straughn <[email protected]> Co-authored-by: Marshall Main <[email protected]> (cherry picked from commit c85062b) Co-authored-by: Joe Peeples <[email protected]>
Resolves #2471.
Preview: Rule exceptions and value lists - Mostly updates the "Create value lists" sections
Note: Docs PR #2546 (New exceptions UI) is also updating portions of the "Rule exceptions and value lists" page, but I think we'll be able to avoid conflicts since we're working in different areas. 🤞