Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Value list exceptions for all rule types #2562

Merged
merged 7 commits into from
Oct 18, 2022

Conversation

joepeeples
Copy link
Contributor

@joepeeples joepeeples commented Oct 11, 2022

Resolves #2471.

Preview: Rule exceptions and value lists - Mostly updates the "Create value lists" sections


Note: Docs PR #2546 (New exceptions UI) is also updating portions of the "Rule exceptions and value lists" page, but I think we'll be able to avoid conflicts since we're working in different areas. 🤞

@github-actions
Copy link

Documentation previews:

@joepeeples joepeeples marked this pull request as ready for review October 11, 2022 18:31
Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small nits. LGTM, thanks!

docs/detections/detections-ui-exceptions.asciidoc Outdated Show resolved Hide resolved
docs/detections/detections-ui-exceptions.asciidoc Outdated Show resolved Hide resolved
Copy link
Contributor

@nastasha-solomon nastasha-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Co-authored-by: Janeen Mikell-Straughn <[email protected]>
Copy link
Contributor

@dplumlee dplumlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@joepeeples joepeeples mentioned this pull request Oct 13, 2022
28 tasks
@joepeeples joepeeples added the readyforQA PRs that are ready for QA review. label Oct 17, 2022
@ghost

This comment was marked as resolved.

@ghost ghost added QA:Validated Issue has been Validated by QA Team and removed readyforQA PRs that are ready for QA review. labels Oct 18, 2022
@joepeeples joepeeples merged commit c85062b into main Oct 18, 2022
mergify bot pushed a commit that referenced this pull request Oct 18, 2022
* Update detections-ui-exceptions.asciidoc

* Smol edits

* Apply suggestions from Janeen's review

Co-authored-by: Janeen Mikell-Straughn <[email protected]>

* Apply suggestions from Marshall's review

Co-authored-by: Marshall Main <[email protected]>

Co-authored-by: Janeen Mikell-Straughn <[email protected]>
Co-authored-by: Marshall Main <[email protected]>
(cherry picked from commit c85062b)
joepeeples added a commit that referenced this pull request Oct 18, 2022
* Update detections-ui-exceptions.asciidoc

* Smol edits

* Apply suggestions from Janeen's review

Co-authored-by: Janeen Mikell-Straughn <[email protected]>

* Apply suggestions from Marshall's review

Co-authored-by: Marshall Main <[email protected]>

Co-authored-by: Janeen Mikell-Straughn <[email protected]>
Co-authored-by: Marshall Main <[email protected]>
(cherry picked from commit c85062b)

Co-authored-by: Joe Peeples <[email protected]>
@joepeeples joepeeples deleted the 2471-value-list-exceptions branch October 18, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] Value list exceptions for all rule types
6 participants