Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] 8.5 Release Notes #2519

Merged
merged 55 commits into from
Nov 1, 2022
Merged

[DOCS] 8.5 Release Notes #2519

merged 55 commits into from
Nov 1, 2022

Conversation

benironside
Copy link
Contributor

@benironside benironside commented Sep 30, 2022

Resolves #2466 and resolves #2429 by creating release notes for 8.5. By the way, would anyone object to our not including the "Breaking changes" or "Known issues" headers when they are empty?

Preview

@github-actions
Copy link

Documentation previews:

@mergify
Copy link
Contributor

mergify bot commented Oct 3, 2022

This pull request is now in conflicts. Could you fix it @benironside? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b issue-2460-big upstream/issue-2460-big
git merge upstream/main
git push upstream issue-2460-big

@nastasha-solomon
Copy link
Contributor

Thanks for setting this up @benironside! It looks like we have some breaking changes to doc in https://github.com/elastic/security-team/issues/4898. The known issue section we can probably omit for now since we haven't been contacted about any yet.

@approksiu
Copy link
Contributor

Hi all, we've added tag has_guide to all the prebuilt detection rules that have Investigation guides (elastic/detection-rules#2297) - please make a note in the release notes if not yet done. Thanks a lot!

@nastasha-solomon
Copy link
Contributor

nastasha-solomon commented Oct 10, 2022

@approksiu thanks for reaching out! Does the change you described affect user's experience when interacting with investigation guides? If it does, would you mind describing whats changed and specifying if the change falls under the category of a new feature, new enhancement, breaking change, or bug fix?

@approksiu
Copy link
Contributor

@nastasha-solomon It is an enhancement, it does not affect interaction with the guides, but enhances interaction with the rules from user perspective. They now can filter out just the rule that have the guides (by selecting has_guide tag) - for example if they want to look for an example of a guide, or want to enable the relevant rule that has a guide provided already.

@nastasha-solomon
Copy link
Contributor

Makes sense, thank you! One more question: at the end of the release note summary for this enhancement, did you want us to link to a specific (and public) PR or issue? If not, we can just omit it. :)

@approksiu
Copy link
Contributor

Thanks @nastasha-solomon ! elastic/detection-rules#2297 - this issue can be linked. Thanks!

@jmikell821 jmikell821 requested review from a team October 12, 2022 19:49
Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, added some line edits.

I also have a few features I've documented that I need to add to the RNs -- I'll add those in another comment, don't want to lose the existing edits

docs/release-notes/8.5.asciidoc Outdated Show resolved Hide resolved
docs/release-notes/8.5.asciidoc Outdated Show resolved Hide resolved
docs/release-notes/8.5.asciidoc Outdated Show resolved Hide resolved
docs/release-notes/8.5.asciidoc Outdated Show resolved Hide resolved
docs/release-notes/8.5.asciidoc Outdated Show resolved Hide resolved
docs/release-notes/8.5.asciidoc Outdated Show resolved Hide resolved
docs/release-notes/8.5.asciidoc Outdated Show resolved Hide resolved
docs/release-notes/8.5.asciidoc Outdated Show resolved Hide resolved
docs/release-notes/8.5.asciidoc Outdated Show resolved Hide resolved
docs/release-notes/8.5.asciidoc Outdated Show resolved Hide resolved
Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All slight nits/suggestions. Thanks for pulling it together!

docs/release-notes/8.5.asciidoc Outdated Show resolved Hide resolved
docs/release-notes/8.5.asciidoc Outdated Show resolved Hide resolved
docs/release-notes/8.5.asciidoc Outdated Show resolved Hide resolved
docs/release-notes/8.5.asciidoc Outdated Show resolved Hide resolved
docs/release-notes/8.5.asciidoc Outdated Show resolved Hide resolved
docs/release-notes/8.5.asciidoc Outdated Show resolved Hide resolved
docs/release-notes/8.5.asciidoc Outdated Show resolved Hide resolved
docs/release-notes/8.5.asciidoc Outdated Show resolved Hide resolved
docs/release-notes/8.5.asciidoc Outdated Show resolved Hide resolved
Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a few tiny tiny nit details, otherwise LGTM!

docs/release-notes/8.5.asciidoc Outdated Show resolved Hide resolved
docs/release-notes/8.5.asciidoc Outdated Show resolved Hide resolved
docs/release-notes/8.5.asciidoc Outdated Show resolved Hide resolved
@nastasha-solomon nastasha-solomon merged commit 9a1b0af into main Nov 1, 2022
@nastasha-solomon nastasha-solomon deleted the issue-2460-big branch November 1, 2022 13:16
mergify bot pushed a commit that referenced this pull request Nov 1, 2022
Co-authored-by: Joe Peeples <[email protected]>
Co-authored-by: Janeen Mikell-Straughn <[email protected]>
Co-authored-by: Devin W. Hurley <[email protected]>
Co-authored-by: nastasha-solomon <[email protected]>
Co-authored-by: nastasha.solomon <[email protected]>
Co-authored-by: tinnytintin10 <[email protected]>
(cherry picked from commit 9a1b0af)
nastasha-solomon added a commit that referenced this pull request Nov 1, 2022
Co-authored-by: Joe Peeples <[email protected]>
Co-authored-by: Janeen Mikell-Straughn <[email protected]>
Co-authored-by: Devin W. Hurley <[email protected]>
Co-authored-by: nastasha-solomon <[email protected]>
Co-authored-by: nastasha.solomon <[email protected]>
Co-authored-by: tinnytintin10 <[email protected]>
Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] Endpoint 8.5 Release Notes [DOCS] 8.5.0 Release Notes