Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] [AWP] [8.2] Session View topic #1824

Merged
merged 48 commits into from
Apr 28, 2022
Merged

[DOCS] [AWP] [8.2] Session View topic #1824

merged 48 commits into from
Apr 28, 2022

Conversation

benironside
Copy link
Contributor

@benironside benironside commented Apr 11, 2022

Resolves #1781 by creating a new documentation page that describes the version of Session View that will be released in 8.2.

Please see the preview here: Session View, and add feedback as suggestions or comments.

I requested reviews from several AWP team leads, please feel free to add members of your teams as reviewers as well.

@benironside benironside self-assigned this Apr 11, 2022
@mergify

This comment was marked as resolved.

@qcorporation qcorporation requested a review from m-sample April 11, 2022 20:13
From either of these tabs, click the *Open Session View* icon for an event or session:

[role="screenshot"]
image::images/session-view-hosts-page-sessions-tab-labeled.png[]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The screenshots might have to be updated based upon this ticket: elastic/kibana#129923 which we "might" add into the 8.2 release

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, subscribed to that issue. NP to update screenshots as needed.

@benironside benironside dismissed dimadavid’s stale review April 21, 2022 16:02

I made the requested changes, and Dima reviewed again and agreed it's improved

Copy link

@dimadavid dimadavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be helpful to users if the following screen captures are shown in context. a full command line from session view with these labels/buttons:
docs/detections/images/session-view-script-button.png
docs/detections/images/session-view-hosts-page-sessions-tab-labeled.png

@benironside benironside dismissed dimadavid’s stale review April 25, 2022 20:20

Updated screenshots to show full command-line context

Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments/suggestions. Looks good - thanks!

docs/detections/session-view.asciidoc Show resolved Hide resolved
docs/detections/session-view.asciidoc Outdated Show resolved Hide resolved
docs/detections/session-view.asciidoc Outdated Show resolved Hide resolved
docs/detections/session-view.asciidoc Outdated Show resolved Hide resolved
docs/detections/session-view.asciidoc Outdated Show resolved Hide resolved
docs/detections/session-view.asciidoc Outdated Show resolved Hide resolved
docs/detections/session-view.asciidoc Outdated Show resolved Hide resolved
docs/detections/session-view.asciidoc Outdated Show resolved Hide resolved
docs/detections/session-view.asciidoc Outdated Show resolved Hide resolved
@benironside benironside added the readyforQA PRs that are ready for QA review. label Apr 26, 2022
@ghost
Copy link

ghost commented Apr 27, 2022

Hi @benironside,

We have reported the 01 issue for the docs related to this PR here:

We will validate this PR once the above issue is fixed.

Thanks!

@ghost ghost removed the readyforQA PRs that are ready for QA review. label Apr 27, 2022
@ghost
Copy link

ghost commented Apr 28, 2022

Hi @benironside,

We tested the linked docs for the reported bugs and found that all the docs are correctly updated as per the latest UI. So we are good to go ahead and merge the changes.

Marking this ticket as 'QA validated'.

Thanks!

@ghost ghost added the QA:Validated Issue has been Validated by QA Team label Apr 28, 2022
@benironside benironside merged commit e8a0c07 into main Apr 28, 2022
@benironside benironside deleted the issue-1781-big branch April 28, 2022 20:14
mergify bot pushed a commit that referenced this pull request Apr 28, 2022
* Add first draft of Session View topic

* Fix bugs

* Testing alternative section headers

* Troubleshoot modified headers, update image

* Minor fixes

* Adds information about what SV displays

* Changes references to "agent" to "Endpoint Security"

* Remove references to output

* Changes "details pane" to "details panel"

* Addresses Mike's, Norrie's, and David's feedback

* Update docs/detections/session-view.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/detections/session-view.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/detections/session-view.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/detections/session-view.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/detections/session-view.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/detections/session-view.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/detections/session-view.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/detections/session-view.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/detections/session-view.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/detections/session-view.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/detections/session-view.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Incorporate Joe's feedback

* Update docs/detections/session-view.asciidoc

Co-authored-by: nastasha-solomon <[email protected]>

* Update docs/detections/session-view.asciidoc

Co-authored-by: nastasha-solomon <[email protected]>

* Update docs/detections/session-view.asciidoc

Co-authored-by: nastasha-solomon <[email protected]>

* Update docs/detections/session-view.asciidoc

Co-authored-by: nastasha-solomon <[email protected]>

* Update docs/detections/session-view.asciidoc

Co-authored-by: nastasha-solomon <[email protected]>

* Update docs/detections/session-view.asciidoc

Co-authored-by: nastasha-solomon <[email protected]>

* Update docs/detections/session-view.asciidoc

Co-authored-by: nastasha-solomon <[email protected]>

* Update docs/detections/session-view.asciidoc

Co-authored-by: nastasha-solomon <[email protected]>

* Update docs/detections/session-view.asciidoc

Co-authored-by: nastasha-solomon <[email protected]>

* Address feedback, update images to latest version of SV

* fixes build error

* troubleshoots images

* Troubleshoots image resolution

* Fixes a stray period

* update button and badge screenshots

* Update docs/detections/session-view.asciidoc

Co-authored-by: Janeen Mikell-Straughn <[email protected]>

* Incorporates Janeen's feedback

* Addresses bug where Authentications tab was present

Co-authored-by: Joe Peeples <[email protected]>
Co-authored-by: nastasha-solomon <[email protected]>
Co-authored-by: Janeen Mikell-Straughn <[email protected]>
(cherry picked from commit e8a0c07)
benironside added a commit that referenced this pull request Apr 28, 2022
* Add first draft of Session View topic

* Fix bugs

* Testing alternative section headers

* Troubleshoot modified headers, update image

* Minor fixes

* Adds information about what SV displays

* Changes references to "agent" to "Endpoint Security"

* Remove references to output

* Changes "details pane" to "details panel"

* Addresses Mike's, Norrie's, and David's feedback

* Update docs/detections/session-view.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/detections/session-view.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/detections/session-view.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/detections/session-view.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/detections/session-view.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/detections/session-view.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/detections/session-view.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/detections/session-view.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/detections/session-view.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/detections/session-view.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/detections/session-view.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Incorporate Joe's feedback

* Update docs/detections/session-view.asciidoc

Co-authored-by: nastasha-solomon <[email protected]>

* Update docs/detections/session-view.asciidoc

Co-authored-by: nastasha-solomon <[email protected]>

* Update docs/detections/session-view.asciidoc

Co-authored-by: nastasha-solomon <[email protected]>

* Update docs/detections/session-view.asciidoc

Co-authored-by: nastasha-solomon <[email protected]>

* Update docs/detections/session-view.asciidoc

Co-authored-by: nastasha-solomon <[email protected]>

* Update docs/detections/session-view.asciidoc

Co-authored-by: nastasha-solomon <[email protected]>

* Update docs/detections/session-view.asciidoc

Co-authored-by: nastasha-solomon <[email protected]>

* Update docs/detections/session-view.asciidoc

Co-authored-by: nastasha-solomon <[email protected]>

* Update docs/detections/session-view.asciidoc

Co-authored-by: nastasha-solomon <[email protected]>

* Address feedback, update images to latest version of SV

* fixes build error

* troubleshoots images

* Troubleshoots image resolution

* Fixes a stray period

* update button and badge screenshots

* Update docs/detections/session-view.asciidoc

Co-authored-by: Janeen Mikell-Straughn <[email protected]>

* Incorporates Janeen's feedback

* Addresses bug where Authentications tab was present

Co-authored-by: Joe Peeples <[email protected]>
Co-authored-by: nastasha-solomon <[email protected]>
Co-authored-by: Janeen Mikell-Straughn <[email protected]>
(cherry picked from commit e8a0c07)

Co-authored-by: benironside <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA:Validated Issue has been Validated by QA Team v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] [8.2] [AWP] Create Session View topic
8 participants