Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS]7.16.0 Release Notes #1210

Merged
merged 32 commits into from
Dec 7, 2021
Merged

[DOCS]7.16.0 Release Notes #1210

merged 32 commits into from
Dec 7, 2021

Conversation

nastasha-solomon
Copy link
Contributor

@nastasha-solomon nastasha-solomon commented Nov 9, 2021

Addresses #1179.

Preview:
Release notes

@nastasha-solomon nastasha-solomon marked this pull request as ready for review November 22, 2021 22:41
Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A few line edits, one question.

docs/release-notes/7.16.asciidoc Outdated Show resolved Hide resolved
docs/release-notes/7.16.asciidoc Outdated Show resolved Hide resolved
docs/release-notes/7.16.asciidoc Outdated Show resolved Hide resolved
docs/release-notes/7.16.asciidoc Outdated Show resolved Hide resolved
docs/release-notes/7.16.asciidoc Outdated Show resolved Hide resolved
docs/release-notes/7.16.asciidoc Outdated Show resolved Hide resolved
Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was super interesting to review some of the linked issues, I hope my comments are helpful and not nitpicky - please feel free to take them with a healthy portion of salt.

docs/release-notes/7.16.asciidoc Outdated Show resolved Hide resolved
docs/release-notes/7.16.asciidoc Outdated Show resolved Hide resolved
docs/release-notes/7.16.asciidoc Show resolved Hide resolved
docs/release-notes/7.16.asciidoc Outdated Show resolved Hide resolved
* Changes the prebuilt indicator match rule's interval and lookback time to one hour ({pull}115185[#115185]).
* Allows exceptions to be exported with rules ({pull}115144[#115144]).
* Improves the formatting of array values and JSON in the *Table* and *JSON* tabs ({pull}115141[#115141]).
* Provides users with a new, simpler way to add data to their environments through the {agent} ({pull}115016[#115016], {pull}112142[#112142]).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Provides users with a new, simpler way to add data to their environments through the {agent} ({pull}115016[#115016], {pull}112142[#112142]).
* Redesigns the welcome pages that appear when no data is present ({pull}115016[#115016], {pull}112142[#112142]).

Maybe I am misreading the linked issues, but I would describe this as something like "Redesigns the welcome pages that appear when no data is present".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm leaning towards leaving this as is because the summary came from @kevinlog. Though, I'm completely open to revising this @kevinlog if you want to blend the two.

docs/release-notes/7.16.asciidoc Outdated Show resolved Hide resolved
docs/release-notes/7.16.asciidoc Outdated Show resolved Hide resolved
Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nastasha-solomon would like to review once more with a fresh view. Thanks!

docs/release-notes/7.16.asciidoc Outdated Show resolved Hide resolved
docs/release-notes/7.16.asciidoc Outdated Show resolved Hide resolved
docs/release-notes/7.16.asciidoc Outdated Show resolved Hide resolved
docs/release-notes/7.16.asciidoc Show resolved Hide resolved
docs/release-notes/7.16.asciidoc Outdated Show resolved Hide resolved
docs/release-notes/7.16.asciidoc Outdated Show resolved Hide resolved
docs/release-notes/7.16.asciidoc Outdated Show resolved Hide resolved
docs/release-notes/7.16.asciidoc Outdated Show resolved Hide resolved
docs/release-notes/7.16.asciidoc Outdated Show resolved Hide resolved
Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few line-edits on the latest PRs!

docs/release-notes/7.16.asciidoc Outdated Show resolved Hide resolved
docs/release-notes/7.16.asciidoc Outdated Show resolved Hide resolved
docs/release-notes/7.16.asciidoc Outdated Show resolved Hide resolved
docs/release-notes/7.16.asciidoc Outdated Show resolved Hide resolved
docs/release-notes/7.16.asciidoc Outdated Show resolved Hide resolved
@nastasha-solomon
Copy link
Contributor Author

nastasha-solomon commented Dec 7, 2021

@jmikell821 going to try the skiplinkcheck command that @gtback reccomended in the techpubs Slack channel to get around these cross-doc links:

11:52:31 INFO:build_docs:Bad cross-document links:
11:52:31 INFO:build_docs: /tmp/docsbuild/target_repo/html/en/cloud-enterprise/2.10/ece-enable-ccs.html contains broken links to:
11:52:31 INFO:build_docs: - en/elasticsearch/reference/7.16/modules-remote-clusters.html#gateway-nodes-selection
11:52:31 INFO:build_docs: - en/elasticsearch/reference/7.16/modules-remote-clusters.html#proxy-mode
11:52:31 INFO:build_docs: - en/elasticsearch/reference/7.16/modules-remote-clusters.html#sniff-mode
11:52:31 INFO:build_docs: /tmp/docsbuild/target_repo/html/en/cloud-enterprise/2.11/ece-cloud-ingest-data.html contains broken links to:
11:52:31 INFO:build_docs: - en/fleet/7.16/elastic-agent-installation-configuration.html
11:52:31 INFO:build_docs: /tmp/docsbuild/target_repo/html/en/cloud-enterprise/2.11/ece-enable-ccs.html contains broken links to:
11:52:31 INFO:build_docs: - en/elasticsearch/reference/7.16/modules-remote-clusters.html#gateway-nodes-selection
11:52:31 INFO:build_docs: - en/elasticsearch/reference/7.16/modules-remote-clusters.html#proxy-mode
11:52:31 INFO:build_docs: - en/elasticsearch/reference/7.16/modules-remote-clusters.html#sniff-mode
11:52:31 INFO:build_docs: /tmp/docsbuild/target_repo/html/en/cloud-enterprise/2.12/ece-cloud-ingest-data.html contains broken links to:
11:52:31 INFO:build_docs: - en/fleet/7.16/elastic-agent-installation-configuration.html
11:52:31 INFO:build_docs: /tmp/docsbuild/target_repo/html/en/cloud-enterprise/2.12/ece-enable-ccs.html contains broken links to:
11:52:31 INFO:build_docs: - en/elasticsearch/reference/7.16/modules-remote-clusters.html#gateway-nodes-selection
11:52:31 INFO:build_docs: - en/elasticsearch/reference/7.16/modules-remote-clusters.html#proxy-mode
11:52:31 INFO:build_docs: - en/elasticsearch/reference/7.16/modules-remote-clusters.html#sniff-mode
11:52:31 INFO:build_docs: /tmp/docsbuild/target_repo/html/en/cloud-enterprise/2.6/ece-enable-ccs.html contains broken links to:
11:52:31 INFO:build_docs: - en/elasticsearch/reference/7.16/modules-remote-clusters.html#gateway-nodes-selection
11:52:31 INFO:build_docs: /tmp/docsbuild/target_repo/html/en/cloud-enterprise/2.7/ece-enable-ccs.html contains broken links to:
11:52:31 INFO:build_docs: - en/elasticsearch/reference/7.16/modules-remote-clusters.html#gateway-nodes-selection
11:52:31 INFO:build_docs: /tmp/docsbuild/target_repo/html/en/cloud-enterprise/2.8/ece-enable-ccs.html contains broken links to:
11:52:31 INFO:build_docs: - en/elasticsearch/reference/7.16/modules-remote-clusters.html#gateway-nodes-selection
11:52:31 INFO:build_docs: /tmp/docsbuild/target_repo/html/en/cloud-enterprise/2.9/ece-enable-ccs.html contains broken links to:
11:52:31 INFO:build_docs: - en/elasticsearch/reference/7.16/modules-remote-clusters.html#gateway-nodes-selection
11:52:31 INFO:build_docs: - en/elasticsearch/reference/7.16/modules-remote-clusters.html#proxy-mode
11:52:31 INFO:build_docs: - en/elasticsearch/reference/7.16/modules-remote-clusters.html#sniff-mode
11:52:31 INFO:build_docs: /tmp/docsbuild/target_repo/html/en/cloud-enterprise/current/ece-cloud-ingest-data.html contains broken links to:
11:52:31 INFO:build_docs: - en/fleet/7.16/elastic-agent-installation-configuration.html
11:52:31 INFO:build_docs: /tmp/docsbuild/target_repo/html/en/cloud-enterprise/current/ece-enable-ccs.html contains broken links to:
11:52:31 INFO:build_docs: - en/elasticsearch/reference/7.16/modules-remote-clusters.html#gateway-nodes-selection
11:52:31 INFO:build_docs: - en/elasticsearch/reference/7.16/modules-remote-clusters.html#proxy-mode
11:52:31 INFO:build_docs: - en/elasticsearch/reference/7.16/modules-remote-clusters.html#sniff-mode
11:52:31 INFO:build_docs: /tmp/docsbuild/target_repo/html/en/cloud/current/ec-azure-marketplace-native.html contains broken links to:
11:52:31 INFO:build_docs: - en/fleet/7.16/elastic-agent-installation-configuration.html
11:52:31 INFO:build_docs: /tmp/docsbuild/target_repo/html/en/cloud/current/ec-cloud-ingest-data.html contains broken links to:
11:52:31 INFO:build_docs: - en/fleet/7.16/elastic-agent-installation-configuration.html
11:52:31 INFO:build_docs: /tmp/docsbuild/target_repo/html/en/cloud/current/ec-enable-ccs.html contains broken links to:
11:52:31 INFO:build_docs: - en/elasticsearch/reference/7.16/modules-remote-clusters.html#gateway-nodes-selection
11:52:31 INFO:build_docs: /tmp/docsbuild/target_repo/html/en/cloud/latest/ec-azure-marketplace-native.html contains broken links to:
11:52:31 INFO:build_docs: - en/fleet/7.16/elastic-agent-installation-configuration.html
11:52:31 INFO:build_docs: /tmp/docsbuild/target_repo/html/en/cloud/latest/ec-cloud-ingest-data.html contains broken links to:
11:52:31 INFO:build_docs: - en/fleet/7.16/elastic-agent-installation-configuration.html
11:52:31 INFO:build_docs: /tmp/docsbuild/target_repo/html/en/cloud/latest/ec-enable-ccs.html contains broken links to:
11:52:31 INFO:build_docs: - en/elasticsearch/reference/7.16/modules-remote-clusters.html#gateway-nodes-selection
11:52:57 runbld>>> <<<<<<<<<<<< SCRIPT EXECUTION END <<<<<<<<<<<<

@nastasha-solomon
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/docs skiplinkcheck

@nastasha-solomon
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/docs skiplinkcheck

@nastasha-solomon
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/docs skiplinkcheck

@nastasha-solomon
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/docs skiplinkcheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants