Update node jose #12
Merged
Update node jose #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 CLA has been signed |
|
(continuing from #11 (comment)) Fixed now! |
added 2 commits
December 28, 2021 14:46
|
Rethinking this:
The only other non-dev dependency this package has is Perhaps, in the spirit of SemVer, this PR should bump this package's version to 2.0.0 and we should state that Node 8 is not supported anymore. WDYT? |
|
@jportner I guess it makes sense to bump it to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-submitting #11.
Resolves #10.
This PR updates the
node-josedependency from version 1.1.0 to 2.0.0.That removes support for Node 6 and Node 8, but I don't think we ever claimed / intended to support those.
node-jose1.1.4 instead to resolve the linked issue.