Increase bulk size to metrics store #962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we specify an explicit bulk size (called `chunk_size` by the Elasticsearch Python client) to improve performance when sending large amounts of metrics documents. After experimenting with different bulk sizes we have settled for a bulk size of 5000 documents per bulk (the default is 500 docs per bulk) which improved throughput by a factor of 2 in our experiments.
danielmitterdorfer
added
enhancement
|
@elasticmachine test this please |
|
Thanks for the review! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we specify an explicit bulk size (called
chunk_sizeby the Elasticsearch Python client) to improve performance when sending
large amounts of metrics documents. After experimenting with different
bulk sizes we have settled for a bulk size of 5000 documents per bulk
(the default is 500 docs per bulk) which improved throughput by a factor
of 2 in our experiments.