Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass plugin params for all plugins #861

Conversation

danielmitterdorfer
Copy link
Member

@danielmitterdorfer danielmitterdorfer commented Jan 10, 2020

Previously plugin parameters were only passed to the plugin descriptor
in certain configurations, especially Rally did not pass plugin
parameters for core plugins. With this commit we ensure that plugin
parameters are passed to all plugin descriptors.

Previously plugin parameters were only passed to the plugin descriptor
in certain configurations, especially Rally did not pass plugin
parameters for core plugins. With this commit we ensure that plugin
parameters are passed to all plugin descriptors.
@danielmitterdorfer danielmitterdorfer added bug Something's wrong :Benchmark Candidate Management Anything affecting how Rally sets up Elasticsearch labels Jan 10, 2020
@danielmitterdorfer danielmitterdorfer added this to the 1.4.0 milestone Jan 10, 2020
@danielmitterdorfer danielmitterdorfer self-assigned this Jan 10, 2020
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@danielmitterdorfer danielmitterdorfer merged commit 9461ce7 into elastic:master Jan 10, 2020
@danielmitterdorfer danielmitterdorfer deleted the pass-plugin-params-to-hook branch January 10, 2020 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Benchmark Candidate Management Anything affecting how Rally sets up Elasticsearch bug Something's wrong
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants