Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command fails with "=", ":" is needed. #610

Merged
merged 1 commit into from
Jan 11, 2019
Merged

Command fails with "=", ":" is needed. #610

merged 1 commit into from
Jan 11, 2019

Conversation

VladMasarik
Copy link
Contributor

No description provided.

@VladMasarik
Copy link
Contributor Author

The option I am talking about is the first one above "on-error"
https://github.com/elastic/rally/blob/master/docs/command_line_reference.rst#on-error

@danielmitterdorfer
Copy link
Member

This is indeed wrong. Thanks for fixing it. Can I please ask you to sign our contributor license agreement with the same email address that you have used for your commit (so it can be matched by the automated check)? Then we can review and merge the PR. :)

@danielmitterdorfer danielmitterdorfer added bug Something's wrong :Docs Changes to the documentation labels Nov 29, 2018
@danielmitterdorfer danielmitterdorfer added this to the 1.0.3 milestone Nov 29, 2018
@danielmitterdorfer danielmitterdorfer added the feedback needed An open question blocks progress label Nov 29, 2018
@danielmitterdorfer
Copy link
Member

@VladMasarik I noticed that I've failed to ping you in my previous comment. Can I please ask you to sign our contributor license agreement with the same email address that you have used for your commit? Then we can review and merge your pull request. :)

@danielmitterdorfer
Copy link
Member

@VladMasarik I would be really happy to merge your PR but can you please sign the contributor license agreement first? I know it is a simple change but we cannot merge the change without your agreement.

@VladMasarik
Copy link
Contributor Author

@danielmitterdorfer Gotcha! Thanks for not closing it even after a month.

@danielmitterdorfer
Copy link
Member

@VladMasarik no worries. Such is life, stuff can always get lost. :) Thanks for following up. I'll merge your PR soon.

@danielmitterdorfer danielmitterdorfer removed the feedback needed An open question blocks progress label Jan 11, 2019
danielmitterdorfer
danielmitterdorfer approved these changes Jan 11, 2019
View reviewed changes
Copy link
Member

@danielmitterdorfer danielmitterdorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielmitterdorfer danielmitterdorfer merged commit b6ee964 into elastic:master Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmitterdorfer danielmitterdorfer danielmitterdorfer approved these changes

Assignees
No one assigned
Labels
bug Something's wrong :Docs Changes to the documentation
Projects
None yet
Milestone
1.0.3
Development

Successfully merging this pull request may close these issues.
2 participants
@VladMasarik @danielmitterdorfer