Require java-10 to build Elasticsearch from source #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dliappis
added
:Benchmark Candidate Management
Similar to the work done for elastic#387, following the merge of the Elasticsearch PR[1], Rally needs to require java-10 to build Elasticsearch from source. Bump the configuration version to 14 and adjust migration of existing configs to support building with java-10. Also add needed test cases and update docs. Note that building from source with java-10 requires, at minimum, gradle 4.5[2]. This helps us remove a number of additional gradle options that were needed for java-9. So for now, building will fail with gradle <4.5, which will won't be a worry at all once we start using `./gradlew`; this is tracked in issue#412. Closes elastic#450 [1] elastic/elasticsearch#29174 [2] gradle/gradle#3892
dliappis
force-pushed
the
require-java-10-to-build-es-from-source
branch
from
3c0f58e to
0df3f7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the work done for #387, following the merge of the
Elasticsearch PR[1], Rally needs to require java-10 to build
Elasticsearch from source.
Bump the configuration version to 14 and adjust migration of existing
configs to support building with java-10. Also add needed test cases
and update docs.
Note that building from source with java-10 requires, at minimum,
gradle 4.5[2]. This helps us remove a number of additional gradle
options that were needed for java-9. So for now, building will fail
with gradle <4.5, which will won't be a worry at all once we start
using
./gradlew; this is tracked in issue#412.Closes #450
[1] elastic/elasticsearch#29174
[2] gradle/gradle#3892