Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new logo on GitHub, PyPI and Read the Docs #1535

Merged
merged 2 commits into from
Jul 4, 2022
Merged

Use new logo on GitHub, PyPI and Read the Docs #1535

merged 2 commits into from
Jul 4, 2022

Conversation

pquentin
Copy link
Member

@pquentin pquentin commented Jun 29, 2022 •
edited
Loading

I repurposed this pull request to include GitHub and PyPI, not only the docs:

  • I removed the "rally" text under the logo to avoid light/dark theme issues (while GitHub and Furo support dark/white logos, PyPI does not).
  • I converted the README to Markdown first to be able to center the logo in a way that works both on PyPI and GitHub

You can see live versions at the following URLs:

GitHub

https://github.com/pquentin/rally/tree/readme-logo

image
image

PyPI

https://test.pypi.org/project/esrally/2.5.1.dev1/

image

Read the Docs

https://esrally--1535.org.readthedocs.build/en/1535/

image
image

@michaelbaamonde
Copy link
Contributor

I think this looks really nice and would be fine with making this change. Not sure if you want additional feedback first, but consider me +1.

@pquentin pquentin changed the title Try Furo theme with new logo Use new logo on GitHub, PyPI and Read the Docs Jun 30, 2022
@pquentin
Copy link
Member Author

I repurposed this pull request to include GitHub and PyPI in addition to docs and would like to know what you think.

michaelbaamonde
michaelbaamonde approved these changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@michaelbaamonde michaelbaamonde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still a fan of this. I'm good with converting the README to Markdown, too.

inqueue
inqueue approved these changes Jun 30, 2022
View reviewed changes
Copy link
Member

@inqueue inqueue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great, thank you for getting it done!

@pquentin pquentin merged commit 0072371 into elastic:master Jul 4, 2022
@pquentin pquentin deleted the furo-logo branch July 4, 2022 05:17
@pquentin pquentin mentioned this pull request Jul 4, 2022
Merged
@pquentin pquentin added this to the 2.6.0 milestone Jul 4, 2022
@pquentin pquentin self-assigned this Jul 4, 2022
@pquentin pquentin added the enhancement Improves the status quo label Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inqueue inqueue inqueue approved these changes

@michaelbaamonde michaelbaamonde michaelbaamonde approved these changes

@danielmitterdorfer danielmitterdorfer Awaiting requested review from danielmitterdorfer

@dliappis dliappis Awaiting requested review from dliappis

@b-deam b-deam Awaiting requested review from b-deam

@DJRickyB DJRickyB Awaiting requested review from DJRickyB

Assignees

@pquentin pquentin

Labels
enhancement Improves the status quo
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@pquentin @michaelbaamonde @inqueue