Switch to native pytest in tests/utils #1387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pquentin
added
:misc
danielmitterdorfer
approved these changes
Nov 22, 2021
tests/utils/convert_test.py
Outdated
| convert.to_bool(value) | ||
| self.assertEqual("Cannot convert [%s] to bool." % value, ctx.exception.args[0]) | ||
| assert "Cannot convert [%s] to bool." % value == ctx.exception.args[0] |
There was a problem hiding this comment.
We could also switch to f-strings here?
There was a problem hiding this comment.
My intention is to this with pyupgrade at some point. Fixed here, though!
tests/utils/io_test.py
Outdated
| self.assertEqual(os.path.expanduser("~"), io.normalize_path("~/Documents/..")) | ||
| assert io.normalize_path("/already/a/normalized/path") == "/already/a/normalized/path" | ||
| assert io.normalize_path("/not/normalized/path/../") == "/not/normalized" | ||
| assert os.path.expanduser("~") == io.normalize_path("~/Documents/..") |
There was a problem hiding this comment.
Should we reverse the order here so the call to io.normalize_path comes first? Then this is consistent with the other assertions.
This was referenced Jan 31, 2022
This was referenced Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two different commits, which should help with the review.