Fix compare subcommand #1192
Merged
Fix compare subcommand #1192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dliappis
force-pushed
the
fix-compare
branch
2 times, most recently
from
ea296af
to
a9be082
Compare
The refactoring in elastic#1175 broken the compare subcommand due to reliance on the `show-in-report` cli argument. As prior to the PR the subcommand parsing logic was obscure the problem surfaced now. This commit defaults the parameter `show-in-report` for the compare subcommand to True. This parameter could be removed in the future, the reason for adding it in the past was that some users relied on parsing the report file and the comparison adds fields (like percentiles) dynamically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The refactoring in #1175 broken the compare subcommand due to reliance
on the
show-in-reportcli argument. As prior to the PR the subcommandparsing logic was obscure the problem surfaced now.
This commit defaults the parameter
show-in-reportfor the comparesubcommand to True. This parameter could be removed in the future,
the reason for adding it in the past was that some users relied on
parsing the report file and the comparison adds fields
(like percentiles) dynamically.