Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure task names are unique #351

Closed
danielmitterdorfer opened this issue Nov 9, 2017 · 1 comment
Closed

Ensure task names are unique #351

danielmitterdorfer opened this issue Nov 9, 2017 · 1 comment
Labels
breaking Non-backwards compatible change enhancement Improves the status quo :Track Management New operations, changes in the track format, track download changes and the like
Milestone

Comments

@danielmitterdorfer
Copy link
Member

Consider the following schedule:

[
    {
      "operation": "my-query",
      "iterations": 100
    },
    {
      "operation": "force-merge"
    },
    {
      "operation": "my-query",
      "iterations": 100
    }
]

Rally uses the operation's name to record metrics. In that case, the summary report will mix the metrics for both invocations of my-query (before and after force-merge) and this is likely not wanted.

Rally should - by default - still use the operation's name as the task name but it should check for duplicates and raise an error. Users then need to define a new property name which defines the task's name. E.g.:

[
    {
      "name": "my-query-no-force-merge",
      "operation": "my-query",
      "iterations": 100
    },
    {
      "operation": "force-merge"
    },
    {
      "name": "my-query-after-force-merge",
      "operation": "my-query",
      "iterations": 100
    }
]

Note: Marking as breaking as tracks that previously got this wrong will start to fail at this point.

@danielmitterdorfer danielmitterdorfer added :Track Management New operations, changes in the track format, track download changes and the like breaking Non-backwards compatible change enhancement Improves the status quo labels Nov 9, 2017
@danielmitterdorfer danielmitterdorfer added this to the 0.8.0 milestone Nov 9, 2017
@danielmitterdorfer
Copy link
Member Author

Reopening in order to also enhance the metrics format (we should store the task and operation name).

danielmitterdorfer added a commit to elastic/rally-eventdata-track that referenced this issue Nov 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Non-backwards compatible change enhancement Improves the status quo :Track Management New operations, changes in the track format, track download changes and the like
Projects
None yet
Development

No branches or pull requests

1 participant