Fix for elastic/logs many-shards-quantitative #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbanasiak
reviewed
Feb 19, 2024
| "request-params": { | ||
| "include_empty_fields": "false" | ||
| } | ||
| "base-operation-type": "raw-request", |
There was a problem hiding this comment.
The base-operation-type parameter makes only sense with a custom runner referenced through "operation-type": "multi-cluster-wrapper". The purpose of it is to execute the base operation on all clusters passed to Rally. I don't think we need it in this challenge, so I would simplify to "operation-type": "raw-request".
There was a problem hiding this comment.
Thanks for the input, corrected!
gareth-ellis
approved these changes
Feb 19, 2024
inqueue
pushed a commit
to inqueue/rally-tracks
that referenced
this pull request
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Track
field-caps-exclude-empty-fieldsnow usesraw-requestin order to work around python client not supporting new optional query parameterinclude_empty_fields.closes #564