TSDB: Fix "duplicates" #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now there we're calculating the `_id` from dimensions I found that we have duplicated `_id`s in our test data. But it's not because we actually measure things three time. No! We just handn't annotated all of the dimensions as `time_series_dimension`s.
nik9000
commented
Mar 14, 2022
tsdb/index.json
Outdated
| @@ -6563,7 +6565,7 @@ | |||
| }, | |||
| "name": { | |||
| "type": "keyword", | |||
| "ignore_above": 1024 | |||
| "time_series_dimension": true | |||
There was a problem hiding this comment.
Sadly, I don't think we can use this one. It's the host name that metricbeat is running on. I don't think that is a sensible thing to split time series on.
I'm pretty sure we do have duplicates. In the |
|
This doesn't remove all duplicates. But it does remove some duplicates. Which is lovely. |
imotov
approved these changes
Mar 15, 2022
| @@ -7816,7 +7818,7 @@ | |||
| }, | |||
| "name": { | |||
| "type": "keyword", | |||
| "ignore_above": 1024 | |||
| "time_series_dimension": true | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now there we're calculating the
_idfrom dimensions I found that wehave duplicated
_ids in our test data. But it's not because weactually measure things three time. No! We just handn't annotated all of
the dimensions as
time_series_dimensions.