Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate sorted indexing challenge in geonames #200

Merged

Conversation

danielmitterdorfer
Copy link
Member

The sorted indexing challenge in the geonames track turns out to be
unstable. As we have other options that are more reliable (such as
http_logs) we deprecate this challenge for the geonames track.

The sorted indexing challenge in the `geonames` track turns out to be
unstable. As we have other options that are more reliable (such as
`http_logs`) we deprecate this challenge for the `geonames` track.
@danielmitterdorfer
Copy link
Member Author

The message will be shown whenever a user attempts to run a race, e.g.:

esrally race --test-mode --track=geonames --challenge=append-sorted-no-conflicts

Or, for testing this PR: checkout this PR and specify --track-path instead of --track.

Copy link
Contributor

@DJRickyB DJRickyB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -269,6 +269,7 @@
{
"name": "append-sorted-no-conflicts",
"description": "Indexes the whole document corpus in an index sorted by country_code field in ascending order. Document ids are unique so all index operations are append only.",
"user-info": "This challenge is deprecated and will be removed soon. Use the corresponding challenge in http_logs to benchmark sorted indices.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL about user-info. Can we document it? Seems useful

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

danielmitterdorfer added a commit to danielmitterdorfer/rally that referenced this pull request Oct 12, 2021
With this commit we document the existing property `user-info` on the
challenge object.

Relates elastic/rally-tracks#200
@danielmitterdorfer danielmitterdorfer merged commit 4b9f1b7 into elastic:master Oct 12, 2021
@danielmitterdorfer danielmitterdorfer deleted the deprecate-sorted branch October 12, 2021 07:01
danielmitterdorfer added a commit that referenced this pull request Oct 12, 2021
The sorted indexing challenge in the `geonames` track turns out to be
unstable. As we have other options that are more reliable (such as
`http_logs`) we deprecate this challenge for the `geonames` track.
danielmitterdorfer added a commit that referenced this pull request Oct 12, 2021
The sorted indexing challenge in the `geonames` track turns out to be
unstable. As we have other options that are more reliable (such as
`http_logs`) we deprecate this challenge for the `geonames` track.
danielmitterdorfer added a commit that referenced this pull request Oct 12, 2021
The sorted indexing challenge in the `geonames` track turns out to be
unstable. As we have other options that are more reliable (such as
`http_logs`) we deprecate this challenge for the `geonames` track.
danielmitterdorfer added a commit that referenced this pull request Oct 12, 2021
The sorted indexing challenge in the `geonames` track turns out to be
unstable. As we have other options that are more reliable (such as
`http_logs`) we deprecate this challenge for the `geonames` track.
danielmitterdorfer added a commit that referenced this pull request Oct 12, 2021
The sorted indexing challenge in the `geonames` track turns out to be
unstable. As we have other options that are more reliable (such as
`http_logs`) we deprecate this challenge for the `geonames` track.
danielmitterdorfer added a commit that referenced this pull request Oct 12, 2021
The sorted indexing challenge in the `geonames` track turns out to be
unstable. As we have other options that are more reliable (such as
`http_logs`) we deprecate this challenge for the `geonames` track.
danielmitterdorfer added a commit to elastic/rally that referenced this pull request Oct 12, 2021
With this commit we document the existing property `user-info` on the
challenge object.

Relates elastic/rally-tracks#200
uparamonau-es added a commit to uparamonau-es/rally-tracks that referenced this pull request Nov 11, 2021
In elastic#200 we agreed to deprecate sorted indexing challenge in geonames, and in elastic#202 we scheduled its removal after grace period.
uparamonau-es added a commit to uparamonau-es/rally-tracks that referenced this pull request Nov 11, 2021
In elastic#200 we agreed to deprecate sorted indexing challenge in geonames, and in elastic#202 we scheduled its removal after grace period.
uparamonau-es added a commit to uparamonau-es/rally-tracks that referenced this pull request Nov 11, 2021
In elastic#200 we agreed to deprecate sorted indexing challenge in geonames, and in elastic#202 we scheduled its removal after grace period.
uparamonau-es added a commit to uparamonau-es/rally-tracks that referenced this pull request Nov 11, 2021
In elastic#200 we agreed to deprecate sorted indexing challenge in geonames, and in elastic#202 we scheduled its removal after grace period.
uparamonau-es added a commit to uparamonau-es/rally-tracks that referenced this pull request Nov 11, 2021
In elastic#200 we agreed to deprecate sorted indexing challenge in geonames, and in elastic#202 we scheduled its removal after grace period.
uparamonau-es added a commit that referenced this pull request Nov 15, 2021
In #200 we agreed to deprecate sorted indexing challenge in geonames, and in #202 we scheduled its removal after grace period.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants