Adjust snapshot branch to build distribution Docker image #88
Conversation
This adds a Dockerfile to the package-storage branch based on which a distribution of the package-registry with packages is built.
| @@ -10,6 +10,8 @@ pipeline { | |||
| DOCKER_REGISTRY_SECRET = 'secret/observability-team/ci/docker-registry/prod' | |||
| PIPELINE_LOG_LEVEL='INFO' | |||
| GO_VERSION = '1.13.12' | |||
| DOCKER_IMG = "${env.DOCKER_REGISTRY}/package-registry/distribution" | |||
There was a problem hiding this comment.
@kuisathaverat for now, I just made this up. Not sure if this is going to work.
The goal is that as soon as this PR is merged, it pushes to docker.elastic.co/package-registry/distribution:snapshot.
There was a problem hiding this comment.
currently, the pipeline uses the BRANCH_NAME as tag so it will push to docker.elastic.co/package-registry/distribution:master, we push for every branch or tag.
if we want to change it to docker.elastic.co/package-registry/distribution:snapshot for the master branch it is easy to make, Do we want to publish other branches to that namespace (docker.elastic.co/package-registry)?
I see that there is a branch name snapshot, it push to docker.elastic.co/package-registry/distribution:snapshot but is not the master branch
There was a problem hiding this comment.
This PR is against the snapshot branch. Does this mean it is just going to work?
There was a problem hiding this comment.
ouch!!, I didn't realize that the PR is against the snapshot branch, yep it makes the thing
| @@ -0,0 +1,15 @@ | |||
| # Here the version of the registry is specified this storage branch uses. | |||
| # It should always be a specific version to make sure builds are reproducible. | |||
| ARG PACKAGE_REGISTRY=57d417a84fa038cfb50a0cd661372c194199b3fd | |||
There was a problem hiding this comment.
@jsoriano Registry version is fixed. Here it is a commit hash but i expect it will become a released version soon.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
|
Somehow if the 0.1.0 version of the base package was around, the base package was not loaded by the registry at all. I couldn't find out yet why but without it works, so leaving it as is. |
|
@kuisathaverat If you are ok with this, I suggest we get this in. As a follow up, I will create the other branches for staging and production off this and then we can start to adjust the services running to point to the right place. |
|
@mtojek At one stage, we should then switch over the release script to this branch and push directly instead of using a release script. We will then need additional script(s) to move things to staging and open pr to production for packages. |
|
@kuisathaverat I hoped after this got merged that |
|
I have opened a PR to add the stages to build the Docker images |
This adds a Dockerfile to the package-storage branch based on which a distribution of the package-registry with packages is built.
To show which versions of a package exist, the `/search` endpoint must support filtering by a package and then return all versions of this package. This introduces the parameter `package` with which queries like `/search?package=mysql` can be created. These results can be used for showing a drop down when upgrading a version to show which other versions exist. To have an example package for testing this, the `multiversion` package was added. It can be queried with `/search?package=multiversion`.
This adds a Dockerfile to the package-storage branch based on which a distribution of the package-registry with packages is built.