[apmpackage] add apm 7.16

[stuartnelson3]

add apmpackage 7.16.0 to snapshot

[elasticmachine]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Start Time: 2021-10-14T09:14:04.055+0000

• Duration: 25 min 39 sec

• Commit: ca99b13

Test stats 🧪

Test	Results
Failed	0
Passed	71
Skipped	0
Total	71

[stuartnelson3]

/test

[stuartnelson3]

Not sure what's going on with the nil pointer deref, mage -debug check appears to be running without issue on my local machine

[stuartnelson3]

/test

[axw]

We haven't bumped the version in the apm-server repo yet -- we normally do that and copy across. Any reason to diverge?

Never mind, I just saw elastic/apm-server#6319

[marclop]

Left a comment on the linked APM server PR about this entry

[stuartnelson3]

ok, going to wait for #2365 to be merged

[jsoriano]

ok, going to wait for #2365 to be merged

Change merged 🙂 but not sure how this would affect this PR. Maybe it was this one: #2392, try to update the branch.

[elasticmachine]

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Start Time: 2021-10-13T09:04:01.904+0000

• Duration: 6 min 34 sec

• Commit: cf41ad2

Steps errors

Expand to view the steps failures

Checks formatting / linting

• Took 0 min 4 sec . View more details here
• Description: mage -debug check

[elasticmachine]

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Start Time: 2021-10-13T09:04:01.904+0000

• Duration: 6 min 34 sec

• Commit: cf41ad2

Steps errors

Expand to view the steps failures

Checks formatting / linting

• Took 0 min 4 sec . View more details here
• Description: mage -debug check

[stuartnelson3]

@jsoriano @mtojek do either of you know what's going wrong with this build?

[2021-10-13T09:09:30.231Z] + mage -debug check
...
[2021-10-13T09:09:33.722Z] DEBUG: 09:09:33.443186 running magefile with mage vars:
[2021-10-13T09:09:33.722Z] MAGEFILE_DEBUG=1
[2021-10-13T09:09:33.722Z] MAGEFILE_GOCMD=go
[2021-10-13T09:09:34.105Z] Error: runtime error: invalid memory address or nil pointer dereference
script returned exit code 1

[mtojek]

Not really, I'm afraid you have to try reproducing it locally.

[mtojek]

This package is versioned as 7.16.0, which is a bit odd comparing to other packages and considering that we don't bind packages with Elastic release trains.

@simitt @ruflin Are we sure about this approach?

[ruflin]

The idea is to bundle the apm, synthetics, endpoint package soon directly with Kibana which indirectly means these will become part of the release train. This does not mean, the packages should not still be available in the registry but that is where the versioning comes from.

[mtojek]

This may cause troubles for our users in the future if they start mixing versions. For example: Kibana 8.3.0 and APM package 7.16.0, because the version constraint allows for it.

I would like to highlight here that our initial principle was to not bind package releases with stack trains.

[ruflin]

If I remember correctly we want to go so far that also the constraint would not allow this. Also these packages are "auto upgraded", basically the user will not have an option to opt out in the future. This applies to only a very small list of packages.

[mtojek]

If I remember correctly we want to go so far that also the constraint would not allow this.

Hm.. interesting. Could you please elaborate more on this?

Also these packages are "auto upgraded", basically the user will not have an option to opt out in the future. This applies to only a very small list of packages.

TIL! Is this list defined in Kibana or in other place? I'd like to learn more about this, e.g. upgrading rules, rollback, etc.

[axw]

If I remember correctly we want to go so far that also the constraint would not allow this.

Hm.. interesting. Could you please elaborate more on this?

APM is a stack-aligned product, and we want to keep the number of variables down by fixing the package version exactly to the version of Kibana.

(Eventually?) we should update the package's constraint to be an exact version match. I think we want to wait for the package to be bundled in Kibana by release-manager before doing this, as otherwise we'll have to manually release patch releases of the package.

Also these packages are "auto upgraded", basically the user will not have an option to opt out in the future. This applies to only a very small list of packages.

TIL! Is this list defined in Kibana or in other place? I'd like to learn more about this, e.g. upgrading rules, rollback, etc.

Yes, in Kibana. Here's the recent PR that added APM and Synthetics to the list: elastic/kibana#114641