Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate all Kibana object filenames #72

Merged
merged 1 commit into from
Oct 29, 2020
Merged

Validate all Kibana object filenames #72

merged 1 commit into from
Oct 29, 2020

Conversation

mtojek
Copy link
Contributor

@mtojek mtojek commented Oct 29, 2020 •
edited
Loading

Issue: #65

This PR validates all remaining Kibana objects (visualizations, searches and maps). Unit tests are included.

@mtojek mtojek requested a review from ycombinator October 29, 2020 14:49
@mtojek mtojek self-assigned this Oct 29, 2020
@elasticmachine
Copy link

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #72 opened]

  • Start Time: 2020-10-29T14:49:11.586+0000

  • Duration: 4 min 53 sec

ycombinator
ycombinator approved these changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mtojek mtojek merged commit f16f186 into elastic:master Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ycombinator ycombinator ycombinator approved these changes

Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mtojek @elasticmachine @ycombinator