Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend system benchmarks spec #512

Merged
merged 5 commits into from
May 2, 2023
Merged

Extend system benchmarks spec #512

merged 5 commits into from
May 2, 2023

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Apr 24, 2023 •
edited
Loading

What does this PR do?

After tinkering with the spec, I found the original definition was limited, so this is an iteration. It also changes naming from e2e to system for consistency with tests.

Checklist

Related issues

@marc-gr marc-gr requested a review from a team as a code owner April 24, 2023 09:21
@marc-gr marc-gr force-pushed the e2e-benchs-new-spec branch from a4241ea to 5dacc67 Compare April 24, 2023 09:22
@marc-gr marc-gr mentioned this pull request Apr 24, 2023
Merged
9 tasks
@elasticmachine
Copy link

elasticmachine commented Apr 24, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-02T09:44:14.913+0000

  • Duration: 9 min 39 sec

Test stats 🧪

Test Results
Failed 0
Passed 774
Skipped 0
Total 774

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (8/8) 💚
Files 67.857% (19/28) 👍
Classes 75.676% (28/37) 👍
Methods 54.237% (64/118) 👍
Lines 41.336% (594/1437) 👍
Conditionals 100.0% (0/0) 💚

@marc-gr marc-gr requested review from aspacca and mrodm April 24, 2023 11:03
jsoriano
jsoriano reviewed Apr 25, 2023
View reviewed changes
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be more specific in the changelog about the improvements done. Also, this change seems to be breaking. I guess it is ok though because this hasn't been implemented yet in elastic-package and nobody will be using it.

spec/changelog.yml Outdated Show resolved Hide resolved
spec/integration/_dev/benchmark/spec.yml Show resolved Hide resolved
@marc-gr marc-gr requested a review from jsoriano April 25, 2023 10:47
@marc-gr marc-gr requested a review from mrodm April 26, 2023 06:15
mrodm
mrodm previously approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@mrodm mrodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mrodm
mrodm approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@mrodm mrodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mrodm mrodm merged commit 3e44a00 into elastic:main May 2, 2023
@aspacca aspacca mentioned this pull request May 15, 2023
Merged
2 tasks
@marc-gr marc-gr deleted the e2e-benchs-new-spec branch May 17, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrodm mrodm mrodm approved these changes

@aspacca aspacca Awaiting requested review from aspacca

@jsoriano jsoriano Awaiting requested review from jsoriano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marc-gr @elasticmachine @jsoriano @mrodm