Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding CI setup files #13

Merged
merged 1 commit into from
Aug 10, 2020
Merged

Adding CI setup files #13

merged 1 commit into from
Aug 10, 2020

Conversation

ycombinator
Copy link
Contributor

@ycombinator ycombinator commented Aug 6, 2020

This PR creates the .ci folder and adds the necessary files under it to setup Jenkins CI jobs for this repository.

Follow up to #12.
Resolves #6.

@ycombinator ycombinator requested review from mtojek and cachedout August 6, 2020 18:33
@ycombinator ycombinator merged commit 6ff0527 into elastic:master Aug 10, 2020
@ycombinator ycombinator deleted the ci branch August 10, 2020 08:36
cleanup()
withMageEnv(){
dir("${BASE_DIR}"){
sh(label: 'Check',script: 'make check')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sh(label: 'Check',script: 'make check')
sh(label: 'Check', script: 'make check')

Tiny nit: Missing space

cleanup()
withMageEnv(){
dir("${BASE_DIR}"){
sh(label: 'Check',script: 'make test')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sh(label: 'Check',script: 'make test')
sh(label: 'Check', script: 'make test')

Tiny nit: missing space

cleanup()
withMageEnv(){
dir("${BASE_DIR}"){
sh(label: 'Check',script: 'make test')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What output does make test produce? Is it something that needs to be processed with junit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment make test will simply run go test -v ./... under the hood: https://github.com/elastic/package-spec/pull/12/files#diff-d635a9f292641eeeb317ef8c83354e7dR16

Would it be better if it output in a junit-compatible format? We could certainly make that happen with something like https://github.com/jstemmer/go-junit-report.

@ycombinator
Copy link
Contributor Author

Sorry @cachedout, I saw your comments after I saw Marcin's LGTM so I merged the PR already. I will make a follow up PR to address your feedback.

@ycombinator ycombinator mentioned this pull request Aug 10, 2020
@cachedout
Copy link

@ycombinator No worries! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup CI
3 participants