Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package type to manifest file #95

Merged
merged 1 commit into from
Sep 10, 2019
Merged

Conversation

ruflin
Copy link
Contributor

@ruflin ruflin commented Sep 10, 2019

Currently the type is not used and the default type is 'integration'. But this gives us the option in the future to also introduce packages which are not integrations, for example for solutions.

Currently the type is not used and the default type is 'integration'. But this gives us the option in the future to also introduce packages which are not integrations, for example for solutions.
@ruflin
Copy link
Contributor Author

ruflin commented Sep 10, 2019

@jfsiii @skh This currently has no effect on the UI I assume but probably good to know it is there.

@ruflin ruflin merged commit 0c7e8c5 into elastic:master Sep 10, 2019
@ruflin ruflin deleted the package-type branch September 10, 2019 07:08
@jfsiii
Copy link

jfsiii commented Sep 10, 2019

I see the docs/api/* files were updated. Out of curiosity, is that automatic when you build/merge/deploy or do you need to remember to "rebuild"?

This change isn't breaking but it is what I was referring to in elastic/kibana#38598 I really want to work out some coordination which removes the human component -- the need to ping one another.

@ruflin
Copy link
Contributor Author

ruflin commented Sep 11, 2019

To update these files I need to run go test . -generate as otherwise my tests fail. +1 on having some automation here. A human thing that will also reduce pings will be that we start using the Changelog and do proper versioning. My plan is to start this today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants