Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use index templates v2 in package 'base' #378

Closed
wants to merge 3 commits into from

Conversation

skh
Copy link
Contributor

@skh skh commented Apr 23, 2020

  • Move the pre-built packages in base over to index templates v2
  • introduces new directory component-template

Do not merge before elastic/kibana#64305 has been merged, as the current EPM implementation can't handle pre-built v2 packages.

@skh skh self-assigned this Apr 23, 2020
Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

My assumption is that in packages and EPM we ONLY support v2 templates. Is this correct?

@@ -0,0 +1,148 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More general question we had around ingest-pipeline directory. Should it be component_template or component-template? What is our rule? Any preference?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no opinion here, I followed the example of ingest-pipeline.

(Kibana saved objects use hyphenation and not snake case, maybe that's how the initial format was derived even for assets that are not Kibana assets.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets keep the - for now. The part where I stumbled over _ is in the ES API.

@skh
Copy link
Contributor Author

skh commented Apr 27, 2020

My assumption is that in packages and EPM we ONLY support v2 templates. Is this correct?

Yes. For a smooth developer experience this week the code in elastic/kibana#64305 will be able to install pre-built v1 templates that are in the base package before this PR is merged, but other than that everything will be v2.

@skh skh marked this pull request as ready for review April 27, 2020 14:56
@ruflin
Copy link
Contributor

ruflin commented Apr 27, 2020

@skh Conflict in the CHANGELOG. And because of my other PR, probably best rebase ...

@@ -0,0 +1,148 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After a rebase, this should become base/1.0.0/.. as the path.

@skh
Copy link
Contributor Author

skh commented Apr 28, 2020

Closed, see #392

@skh skh closed this Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants