-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logs: add stream input vars #281
Conversation
- /opt/apache-activemq-*/data/audit.log* | ||
name: paths | ||
os.darwin: | ||
- /usr/local/apache-activemq-*/data/audit.log* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The syntax in the package is slightly different because of the UI. It has also a default
part inside: https://github.com/elastic/package-registry/blob/master/dev/packages/example/nginx-1.2.0/dataset/access/manifest.yml#L29
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about that. Fixed.
title: Activemq Broker Metrics | ||
release: ga | ||
type: metrics | ||
streams: | ||
- input: TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting that this will pass :-)
magefile.go
Outdated
@@ -32,7 +32,7 @@ var ( | |||
|
|||
publicDir = "./public" | |||
buildDir = "./build" | |||
packagePaths = []string{"./dev/packages/generated/", "./dev/packages/example/"} | |||
packagePaths = []string{"./dev/packages/generated/", "./dev/packages/example/", "./dev/packages/beats/"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking if we should add it here already or not. I like that it does validate the packages. But I'm wondering if they should already served. The good news is I assume things like nginx and system package keep working, as they have a never version number.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mtojek To get this PR in, can you remove this and merge it without it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, not a problem. Reverted.
This PR adds variables to logs stream input.
Blocker - I'm opening this as draft, because there is a design issue to be solved. If both, metricbeat and filebeat, have a dataset with the same name (e.g. aws - elb), thedataset/manifest.yml
can't define two different types.see
cloudtrail/manifest.yml
:As there is no metricbeat module forcloudtrail
, this file hasn't been overridden (opposite to some other aws datasets).Fixed by creating two directories for datasets having the same name (e.g.
cloudwatch-metrics
andcloudwatch-logs
).BTW. Package validation passed:
BTW2. Packages are properly pulled and presented by Kibana's ingestManager
Issue: #221