Import "beats" dashboards #247
Conversation
| // | ||
| // If you need insert keys containing dots then you must use bracket notation | ||
| // to insert values (e.g. m[key] = value). | ||
| func (m mapStr) put(key string, value interface{}) (interface{}, error) { |
There was a problem hiding this comment.
@urso We should really put mapStr in its own packages. I also had other uses in the past for it.
| } | ||
|
|
||
| request, err := http.NewRequest("POST", | ||
| fmt.Sprintf("http://%s/api/kibana/dashboards/import?force=true", km.hostPort), |
There was a problem hiding this comment.
What is force doing here? Just curious
There was a problem hiding this comment.
Query parameters
force
(Optional, boolean) Overwrite any existing objects on ID conflict.
dev/import-beats/kibana.go
Outdated
| if os.IsNotExist(err) { | ||
| log.Printf("\tno dashboards present, skipped (modulePath: %s)", modulePath) | ||
| return kibanaContent{}, nil | ||
| } else if err != nil { |
There was a problem hiding this comment.
Nit: Problably no else needed as you return in the if clause above.
| return nil, errors.Wrapf(err, "retrieving id failed") | ||
| } | ||
|
|
||
| extracted[id.(string)+".json"] = data |
There was a problem hiding this comment.
The id of the saved object becomes the name? I like that.
| "kibanaSavedObjectMeta": { | ||
| "searchSourceJSON": "{\"filter\":[],\"query\":{\"language\":\"kuery\",\"query\":\"\"}}" | ||
| }, | ||
| "optionsJSON": "{\"hidePanelTitles\":false,\"useMargins\":true}", |
There was a problem hiding this comment.
The JSON strings should be decoded inside the package. I think you have all the logic for it already in place for the encoding, otherwise see #214
There was a problem hiding this comment.
Hmm... if you want to upload them to Kibana, you need to encode them again. I was wondering if it's not better to keep them encoded in packages as well. WDYT?
There was a problem hiding this comment.
The reason we decode them is for versioning purpose. If you change anything small int he visualisation and then get a PR with the change, it is almost impossible to figure out what change. That is the reason we switched to the decoded format in Beats some while ago and I would like also to use it here. My hope is that in the future Kibana directly supports the decoded option.
The encoding currently happens in the build step.
There was a problem hiding this comment.
Ah, you're right! Versioning is a killer argument in this thread.
I've just pushed a change that decodes fields.
I think there is no need to pull them out. Once you POST them to Kibana, in the response you receive migrated/converted objects. |
|
That you get it in the response was the piece I was missing. This simplifies things! |
This PR extends "import-beats" script to pull dashboards and visualizations.
I think we can iterate on top (index names, etc.) of this to come a final version of Kibana artifacts.
Issue: #221