-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parent fields for categories returned by the proxy mode #1004
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Mario - good catch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This PR adds the missing fields related to subcategories in the categories entrypoint with proxy mode.
Currently, the output was missing
parentId
andparentTitle
. Example:Adding those fields to the struct, the same request:
How to test this change
Test with the current production version:
Test with the changes proposed in this PR:
docker build --no-cache -t docker.elastic.co/package-registry/package-registry:v1.19.1 -f Dockerfile .