Address PR comments

elastic · Apr 1, 2020 · b4ffdfb · b4ffdfb
1 parent 2d9c7c5
commit b4ffdfb
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 7 deletions.
diff --git a/dev/packages/alpha/mysql-0.0.2/dataset/error/manifest.yml b/dev/packages/alpha/mysql-0.0.2/dataset/error/manifest.yml
@@ -15,7 +15,7 @@ streams:
     - /var/log/mysqld.log*
     os.darwin:
       default:
-      - /usr/local/var/mysql/{{.builtin.hostname}}.{{.builtin.domain}}.err*
+      - /usr/local/var/mysql/localhost.localdomain.err*
     os.windows:
       default:
       - c:/programdata/MySQL/MySQL Server*/error.log*

diff --git a/dev/packages/alpha/mysql-0.0.2/dataset/galera_status/manifest.yml b/dev/packages/alpha/mysql-0.0.2/dataset/galera_status/manifest.yml
@@ -12,7 +12,10 @@ streams:
     default: 10s
   - name: raw
     type: bool
-    title: Raw (all fields from "SHOW /*!50002 GLOBAL */ STATUS;")
+    title: Raw
+    description: >
+      When enabled, in addition to the existing data structure, all fields available from the mysql service through
+      "SHOW /*!50002 GLOBAL */ STATUS;" will be added to the event.
     default: false
   title: MySQL galera_status metrics
   description: Collect MySQL galera_status metrics
diff --git a/dev/packages/alpha/mysql-0.0.2/dataset/slowlog/manifest.yml b/dev/packages/alpha/mysql-0.0.2/dataset/slowlog/manifest.yml
@@ -12,10 +12,9 @@ streams:
     show_user: true
     default:
     - /var/log/mysql/mysql-slow.log*
-    - /var/lib/mysql/{{.builtin.hostname}}-slow.log
     os.darwin:
       default:
-        - /usr/local/var/mysql/{{.builtin.hostname}}-slow.log*
+        - /usr/local/var/mysql/localhost-slow.log*
     os.windows:
       default:
         - c:/programdata/MySQL/MySQL Server*/mysql-slow.log*

diff --git a/dev/packages/alpha/mysql-0.0.2/dataset/status/manifest.yml b/dev/packages/alpha/mysql-0.0.2/dataset/status/manifest.yml
@@ -12,7 +12,10 @@ streams:
     default: 10s
   - name: raw
     type: bool
-    title: Raw (all fields from "SHOW /*!50002 GLOBAL */ STATUS;")
+    title: Raw
+    description: >
+      When enabled, in addition to the existing data structure, all fields available from the mysql service through
+      "SHOW /*!50002 GLOBAL */ STATUS;" will be added to the event.
     default: false
   title: MySQL status metrics
   description: Collect MySQL status metrics
diff --git a/dev/packages/alpha/mysql-0.0.2/manifest.yml b/dev/packages/alpha/mysql-0.0.2/manifest.yml
@@ -34,9 +34,11 @@ datasources:
   description: Collect logs and metrics from MySQL instances
   inputs:
   - type: logs
-    description: Collecting MySQL logs
+    title: Collect logs from MySQL hosts
+    description: Collecting MySQL error and slowlog logs
   - type: mysql/metrics
-    description: Collecting MySQL metrics
+    title: Collect metrics from MySQL hosts
+    description: Collecting MySQL status and galera_status metrics
     vars:
       - name: hosts
         type: text