Set GenAi subtype for spans

elastic · Dec 3, 2024 · 0075c49 · 0075c49
1 parent 9daa1d2
commit 0075c49
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 4 deletions.
diff --git a/enrichments/trace/internal/elastic/resource.go b/enrichments/trace/internal/elastic/resource.go
@@ -22,7 +22,7 @@ import (
 
 	"github.com/elastic/opentelemetry-lib/enrichments/trace/config"
 	"go.opentelemetry.io/collector/pdata/pcommon"
-	semconv "go.opentelemetry.io/collector/semconv/v1.25.0"
+	semconv "go.opentelemetry.io/collector/semconv/v1.26.0"
 )
 
 // EnrichResource derives and adds Elastic specific resource attributes.

diff --git a/enrichments/trace/internal/elastic/resource_test.go b/enrichments/trace/internal/elastic/resource_test.go
@@ -24,7 +24,7 @@ import (
 	"github.com/google/go-cmp/cmp"
 	"github.com/stretchr/testify/assert"
 	"go.opentelemetry.io/collector/pdata/pcommon"
-	semconv "go.opentelemetry.io/collector/semconv/v1.25.0"
+	semconv "go.opentelemetry.io/collector/semconv/v1.26.0"
 )
 
 func TestResourceEnrich(t *testing.T) {

diff --git a/enrichments/trace/internal/elastic/span.go b/enrichments/trace/internal/elastic/span.go
@@ -33,7 +33,7 @@ import (
 	"github.com/elastic/opentelemetry-lib/enrichments/trace/config"
 	"go.opentelemetry.io/collector/pdata/pcommon"
 	"go.opentelemetry.io/collector/pdata/ptrace"
-	semconv "go.opentelemetry.io/collector/semconv/v1.25.0"
+	semconv "go.opentelemetry.io/collector/semconv/v1.26.0"
 	tracepb "go.opentelemetry.io/proto/otlp/trace/v1"
 	"google.golang.org/grpc/codes"
 )
@@ -82,6 +82,7 @@ type spanEnrichmentContext struct {
 	isHTTP                   bool
 	isDB                     bool
 	messagingDestinationTemp bool
+	isGenAi                  bool
 }
 
 func (s *spanEnrichmentContext) Enrich(span ptrace.Span, cfg config.Config) {
@@ -171,6 +172,8 @@ func (s *spanEnrichmentContext) Enrich(span ptrace.Span, cfg config.Config) {
 		case semconv.AttributeDBSystem:
 			s.isDB = true
 			s.dbSystem = v.Str()
+		case semconv.AttributeGenAiSystem:
+			s.isGenAi = true
 		}
 		return true
 	})
@@ -361,6 +364,9 @@ func (s *spanEnrichmentContext) setSpanTypeSubtype(span ptrace.Span) {
 	case s.isHTTP:
 		spanType = "external"
 		spanSubtype = "http"
+	case s.isGenAi:
+		spanType = "external"
+		spanSubtype = "genai"
 	default:
 		switch span.Kind() {
 		case ptrace.SpanKindInternal:

diff --git a/enrichments/trace/internal/elastic/span_test.go b/enrichments/trace/internal/elastic/span_test.go
@@ -30,7 +30,7 @@ import (
 	"github.com/stretchr/testify/assert"
 	"go.opentelemetry.io/collector/pdata/pcommon"
 	"go.opentelemetry.io/collector/pdata/ptrace"
-	semconv "go.opentelemetry.io/collector/semconv/v1.25.0"
+	semconv "go.opentelemetry.io/collector/semconv/v1.26.0"
 	tracepb "go.opentelemetry.io/proto/otlp/trace/v1"
 	"google.golang.org/grpc/codes"
 )