Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[connector/spanmetrics] Add micro and nano secs unit to histogram #80

Merged
merged 2 commits into from
Jul 31, 2024
Merged

[connector/spanmetrics] Add micro and nano secs unit to histogram #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c238c3b
[connector/spanmetrics] Add micro and nano secs unit to histogram
lahsivjar Jul 31, 2024
232617b
Merge branch 'main' into add-more-histo-units
lahsivjar Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions connector/spanmetricsconnectorv2/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ var (
type MetricUnit string

const (
MetricUnitNs MetricUnit = "ns"
MetricUnitUs MetricUnit = "us"
MetricUnitMs MetricUnit = "ms"
MetricUnitS MetricUnit = "s"
)
Expand Down
2 changes: 2 additions & 0 deletions connector/spanmetricsconnectorv2/histogram.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ var (
// metricUnitToDivider gives a value that could used to divide the
// nano precision duration to the required unit specified in config.
metricUnitToDivider = map[MetricUnit]float64{
MetricUnitNs: float64(time.Nanosecond.Nanoseconds()),
MetricUnitUs: float64(time.Microsecond.Nanoseconds()),
MetricUnitMs: float64(time.Millisecond.Nanoseconds()),
MetricUnitS: float64(time.Second.Nanoseconds()),
}
Expand Down