-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add elastictraceprocessor for enriching traces #33
Conversation
Converting to draft until the otel-lib PR is merged and released |
toolchain go1.22.4 | ||
|
||
require ( | ||
github.com/elastic/opentelemetry-lib v0.7.4-0.20240718095211-7190eff24069 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[For reviewers] I have kept the otel-lib pointed to main because the component is still in development. I will fix a version once the component is in a somewhat stable state.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wdyt of adding the processor in the CI testing distribution too? That will ensure the component can be embedded in a collector. https://github.com/elastic/opentelemetry-collector-components/tree/main/distributions/elastic-components#contributing
@rogercoll I was thinking of doing that once I had the remaining bits to create the full pipeline as it is supposed to work. This would require a connector that would create metrics from the enriched docs. Does that sound good to you, or do you think I should add it now? |
The test failures are due to #38 |
Definitely, let's wait until the full pipeline is set up 👍 |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, let's wait until #38 is merged
Adds elastic traces processsor responsible for enriching the OTel traces with elastic specific attributes.
To be merged after elastic/opentelemetry-lib#46 is merged and released.
Related to: https://github.com/elastic/opentelemetry-dev/issues/305