Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add elastictraceprocessor for enriching traces #33

Merged
merged 6 commits into from
Jul 19, 2024

Conversation

lahsivjar
Copy link
Contributor

Adds elastic traces processsor responsible for enriching the OTel traces with elastic specific attributes.

To be merged after elastic/opentelemetry-lib#46 is merged and released.

Related to: https://github.com/elastic/opentelemetry-dev/issues/305

@lahsivjar lahsivjar requested a review from a team as a code owner July 15, 2024 17:29
@lahsivjar lahsivjar marked this pull request as draft July 15, 2024 17:34
@lahsivjar
Copy link
Contributor Author

Converting to draft until the otel-lib PR is merged and released

@lahsivjar lahsivjar marked this pull request as ready for review July 18, 2024 09:55
@lahsivjar lahsivjar requested review from a team and axw July 18, 2024 09:56
toolchain go1.22.4

require (
github.com/elastic/opentelemetry-lib v0.7.4-0.20240718095211-7190eff24069
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[For reviewers] I have kept the otel-lib pointed to main because the component is still in development. I will fix a version once the component is in a somewhat stable state.

Copy link
Contributor

@rogercoll rogercoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wdyt of adding the processor in the CI testing distribution too? That will ensure the component can be embedded in a collector. https://github.com/elastic/opentelemetry-collector-components/tree/main/distributions/elastic-components#contributing

@lahsivjar
Copy link
Contributor Author

lahsivjar commented Jul 18, 2024

Wdyt of adding the processor in the CI testing distribution too? That will ensure the component can be embedded in a collector. https://github.com/elastic/opentelemetry-collector-components/tree/main/distributions/elastic-components#contributing

@rogercoll I was thinking of doing that once I had the remaining bits to create the full pipeline as it is supposed to work. This would require a connector that would create metrics from the enriched docs. Does that sound good to you, or do you think I should add it now?

@lahsivjar
Copy link
Contributor Author

The test failures are due to #38

@rogercoll
Copy link
Contributor

Does that sound good to you, or do you think I should add it now?

Definitely, let's wait until the full pipeline is set up 👍

@lahsivjar
Copy link
Contributor Author

lahsivjar commented Jul 18, 2024

Thanks @rogercoll , merging this now! (needs approval)

@lahsivjar lahsivjar enabled auto-merge (squash) July 18, 2024 17:00
Copy link
Contributor

@rogercoll rogercoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, let's wait until #38 is merged

@lahsivjar lahsivjar merged commit 07f70b1 into elastic:main Jul 19, 2024
5 of 11 checks passed
@lahsivjar lahsivjar deleted the elastictracep branch July 19, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants