-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sensitive information is already being redacted from diagnostics #2849
Conversation
the troubleshooting guide needs to be updated due to this merge: elastic/elastic-agent#566
A documentation preview will be available soon: |
This pull request does not have a backport label. Could you fix it @nimarezainia? 🙏
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I think you want to backport this to 8.4, no? If so, don't forget to add the backport labels.
i'll wait for @cmacknz to confirm. I'm seeing some conflicting data that this may actually had been inadvertently undone by the V2 project. Craig, could you please confirm if this is an issue currently. |
This pull request is now in conflict. Could you fix it @nimarezainia? 🙏
|
We just moved the ingest documentation to elastic/ingest-docs. Once we hear back from @cmacknz, I'll handle opening a new PR and backporting. |
@cmacknz can you confirm if this is still an issue |
adding review comments
@bmorelli25 I made the recommended changes. hope this doesn't conflict with what you suggested here |
Thanks, both! I've cherry-picked Nima's commits to the new |
the troubleshooting guide needs to be updated due to this merge: elastic/elastic-agent#566