Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[agent] Add documentation for Agent encryption at rest #2368

Merged
merged 2 commits into from
Nov 18, 2022
Merged

[agent] Add documentation for Agent encryption at rest #2368

merged 2 commits into from
Nov 18, 2022

Conversation

andrewvc
Copy link
Contributor

Based on elastic/elastic-agent#398 and a discussion with @cmacknz .

It's a somewhat common ask from synthetics users.

@andrewvc
[agent] Add documentation for Agent encryption at rest
62331d1 
Based on elastic/elastic-agent#398
and a discussion with @cmacknz .

It's a somewhat common ask from synthetics users.
@andrewvc andrewvc requested a review from dedemorton as a code owner November 15, 2022 21:52
@github-actions
Copy link
Contributor

A documentation preview will be available soon:

andrewvc
andrewvc commented Nov 15, 2022
View reviewed changes
docs/en/ingest-management/elastic-agent/elastic-agent-encryption.asciidoc Outdated
At a high level, Elastic Agent receives configuration data from Fleet Server over an encrypted connection, persists those secrets in an encrypted form on disk.
This persistence is necessary to allow agents to continue to operate, even in the event of a loss of connectivity to the Fleet server.

The entirety of the Fleet Agent Policy is encrypted at rest, but is recoverable if the user has access to both the encrypted configuration data and the associated key.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we double-confirm this @cmacknz ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aleksmaus would be good to have you review this as well.

@mergify
Copy link
Contributor

mergify bot commented Nov 15, 2022

This pull request does not have a backport label. Could you fix it @andrewvc? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Nov 15, 2022
dedemorton
dedemorton reviewed Nov 16, 2022
View reviewed changes
Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor copy edits. Thank you for adding this!

docs/en/ingest-management/elastic-agent/elastic-agent-encryption.asciidoc Outdated Show resolved Hide resolved
docs/en/ingest-management/elastic-agent/elastic-agent-encryption.asciidoc Outdated Show resolved Hide resolved
docs/en/ingest-management/elastic-agent/elastic-agent-encryption.asciidoc Outdated Show resolved Hide resolved
docs/en/ingest-management/elastic-agent/elastic-agent-encryption.asciidoc Outdated Show resolved Hide resolved
docs/en/ingest-management/elastic-agent/elastic-agent-encryption.asciidoc Outdated Show resolved Hide resolved
docs/en/ingest-management/elastic-agent/elastic-agent-encryption.asciidoc Outdated Show resolved Hide resolved
docs/en/ingest-management/elastic-agent/elastic-agent-encryption.asciidoc Outdated Show resolved Hide resolved
docs/en/ingest-management/elastic-agent/elastic-agent-encryption.asciidoc Outdated Show resolved Hide resolved
docs/en/ingest-management/elastic-agent/elastic-agent-encryption.asciidoc Outdated Show resolved Hide resolved
docs/en/ingest-management/elastic-agent/elastic-agent-encryption.asciidoc Outdated Show resolved Hide resolved
@andrewvc andrewvc added backport-8.5 Automated backport with mergify Team:Elastic-Agent Label for the Agent team labels Nov 16, 2022
@mergify mergify bot removed the backport-skip Skip notification from the automated backport with mergify label Nov 16, 2022
@andrewvc @dedemorton
Apply suggestions from code review
53b0409 
Thanks for the copy edits Dede!

Co-authored-by: DeDe Morton <[email protected]>
dedemorton
dedemorton approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc changes LGTM.

@andrewvc
Copy link
Contributor Author

Great, just need to get final signoff from @aleksmaus

aleksmaus
aleksmaus approved these changes Nov 18, 2022
View reviewed changes
Copy link

@aleksmaus aleksmaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewvc andrewvc merged commit 7996f31 into elastic:main Nov 18, 2022
@andrewvc andrewvc deleted the fleen-enc-docs branch November 18, 2022 21:15
mergify bot pushed a commit that referenced this pull request Nov 18, 2022
@andrewvc @mergify
[agent] Add documentation for Agent encryption at rest (#2368)
16593a0 
* [agent] Add documentation for Agent encryption at rest

Based on elastic/elastic-agent#398
and a discussion with @cmacknz .

It's a somewhat common ask from synthetics users.

* Apply suggestions from code review

Thanks for the copy edits Dede!

Co-authored-by: DeDe Morton <[email protected]>

Co-authored-by: DeDe Morton <[email protected]>
(cherry picked from commit 7996f31)
@mergify mergify bot mentioned this pull request Nov 18, 2022
Merged
@andrewvc
Copy link
Contributor Author

@Mergifyio backport 8.6

andrewvc added a commit that referenced this pull request Nov 18, 2022
@mergify @andrewvc
[agent] Add documentation for Agent encryption at rest (#2368) (#2388)
c5bec02 
* [agent] Add documentation for Agent encryption at rest

Based on elastic/elastic-agent#398
and a discussion with @cmacknz .

It's a somewhat common ask from synthetics users.

* Apply suggestions from code review

Thanks for the copy edits Dede!

Co-authored-by: DeDe Morton <[email protected]>

Co-authored-by: DeDe Morton <[email protected]>
(cherry picked from commit 7996f31)

Co-authored-by: Andrew Cholakian <[email protected]>
mergify bot pushed a commit that referenced this pull request Nov 18, 2022
@andrewvc @mergify
[agent] Add documentation for Agent encryption at rest (#2368)
76230a3 
* [agent] Add documentation for Agent encryption at rest

Based on elastic/elastic-agent#398
and a discussion with @cmacknz .

It's a somewhat common ask from synthetics users.

* Apply suggestions from code review

Thanks for the copy edits Dede!

Co-authored-by: DeDe Morton <[email protected]>

Co-authored-by: DeDe Morton <[email protected]>
(cherry picked from commit 7996f31)
@mergify mergify bot mentioned this pull request Nov 18, 2022
Merged
@mergify
Copy link
Contributor

mergify bot commented Nov 18, 2022

backport 8.6

✅ Backports have been created

andrewvc added a commit that referenced this pull request Nov 18, 2022
@mergify @andrewvc
[agent] Add documentation for Agent encryption at rest (#2368) (#2389)
8038bcd 
* [agent] Add documentation for Agent encryption at rest

Based on elastic/elastic-agent#398
and a discussion with @cmacknz .

It's a somewhat common ask from synthetics users.

* Apply suggestions from code review

Thanks for the copy edits Dede!

Co-authored-by: DeDe Morton <[email protected]>

Co-authored-by: DeDe Morton <[email protected]>
(cherry picked from commit 7996f31)

Co-authored-by: Andrew Cholakian <[email protected]>
@paulb-elastic paulb-elastic mentioned this pull request Nov 22, 2022
Closed
bmorelli25 pushed a commit to bmorelli25/observability-docs that referenced this pull request Apr 11, 2023
@andrewvc @dedemorton
[agent] Add documentation for Agent encryption at rest (elastic#2368)
b6899b2 
* [agent] Add documentation for Agent encryption at rest

Based on elastic/elastic-agent#398
and a discussion with @cmacknz .

It's a somewhat common ask from synthetics users.

* Apply suggestions from code review

Thanks for the copy edits Dede!

Co-authored-by: DeDe Morton <[email protected]>

Co-authored-by: DeDe Morton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dedemorton dedemorton dedemorton approved these changes

@aleksmaus aleksmaus aleksmaus approved these changes

@cmacknz cmacknz Awaiting requested review from cmacknz

Assignees
No one assigned
Labels
backport-8.5 Automated backport with mergify Team:Elastic-Agent Label for the Agent team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrewvc @aleksmaus @cmacknz @dedemorton