Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Add a dev-tools/ci.bat script to automate the Windows portion of the CI #31

Merged
merged 2 commits into from
Apr 5, 2018
Merged

[ML] Add a dev-tools/ci.bat script to automate the Windows portion of the CI #31

merged 2 commits into from
Apr 5, 2018

Conversation

droberts195
Copy link
Contributor

@droberts195 droberts195 commented Mar 29, 2018

To facilitate migration from ML team CI to Infra CI we need to make the
steps triggered by Jenkins as simple as possible.

This change adds a ci script that can be used for Windows.

(#29 is the corresponding change for Linux/macOS.)

To facilitate migration from ML team CI to Infra CI we need to make the
steps triggered by Jenkins as simple as possible.

This change adds a ci script that can be used for Windows.
Copy link
Contributor

@edsavage edsavage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Dave. Just a question regarding the copyright date.

dev-tools/ci.bat Outdated
rem
rem ELASTICSEARCH CONFIDENTIAL
rem
rem Copyright (c) 2017 Elasticsearch BV. All Rights Reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the date be bumped to 2018?

@droberts195
Copy link
Contributor Author

The idea is that Infra CI would run this on a worker VM set up using a provisioning script very similar to the one used by release manager. The difference would be that the VMs would run in EC2 or GCP rather than locally in VirtualBox.

@droberts195 droberts195 merged commit 306bae4 into elastic:master Apr 5, 2018
@droberts195 droberts195 deleted the windows_ci_script branch April 5, 2018 07:55
droberts195 added a commit that referenced this pull request Apr 5, 2018
… the CI (#31)

To facilitate migration from ML team CI to Infra CI we need to make the
steps triggered by Jenkins as simple as possible.

This change adds a ci script that can be used for Windows.
droberts195 added a commit that referenced this pull request Apr 23, 2018
… the CI (#31)

To facilitate migration from ML team CI to Infra CI we need to make the
steps triggered by Jenkins as simple as possible.

This change adds a ci script that can be used for Windows.
droberts195 added a commit that referenced this pull request Apr 23, 2018
… the CI (#31)

To facilitate migration from ML team CI to Infra CI we need to make the
steps triggered by Jenkins as simple as possible.

This change adds a ci script that can be used for Windows.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants