-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Add a dev-tools/ci.bat script to automate the Windows portion of the CI #31
Conversation
To facilitate migration from ML team CI to Infra CI we need to make the steps triggered by Jenkins as simple as possible. This change adds a ci script that can be used for Windows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good Dave. Just a question regarding the copyright date.
dev-tools/ci.bat
Outdated
rem | ||
rem ELASTICSEARCH CONFIDENTIAL | ||
rem | ||
rem Copyright (c) 2017 Elasticsearch BV. All Rights Reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the date be bumped to 2018?
The idea is that Infra CI would run this on a worker VM set up using a provisioning script very similar to the one used by release manager. The difference would be that the VMs would run in EC2 or GCP rather than locally in VirtualBox. |
… the CI (#31) To facilitate migration from ML team CI to Infra CI we need to make the steps triggered by Jenkins as simple as possible. This change adds a ci script that can be used for Windows.
… the CI (#31) To facilitate migration from ML team CI to Infra CI we need to make the steps triggered by Jenkins as simple as possible. This change adds a ci script that can be used for Windows.
… the CI (#31) To facilitate migration from ML team CI to Infra CI we need to make the steps triggered by Jenkins as simple as possible. This change adds a ci script that can be used for Windows.
To facilitate migration from ML team CI to Infra CI we need to make the
steps triggered by Jenkins as simple as possible.
This change adds a ci script that can be used for Windows.
(#29 is the corresponding change for Linux/macOS.)