[ML] Fix influencer count and influence calculation #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hendrikmuhs
commented
Jul 10, 2018
| params, influencedValue[0]); | ||
| if (computeInfluencedValue(value, count, i->second.first, i->second.second, | ||
| params, influencedValue[0]) == false) { | ||
| LOG_ERROR(<< "Failed to compute influencer value"); |
There was a problem hiding this comment.
@tveasey do you have a better idea for this error message?
There was a problem hiding this comment.
I think, at least for us, it is very useful to see the function arguments, i.e. value, count, i->second.first and i->second.second.
tveasey
approved these changes
Jul 11, 2018
| } | ||
| }; | ||
|
|
||
| //! \brief Computes the value of the variance statistic on a set difference. | ||
| class CVarianceDifference { | ||
| public: | ||
| //! Features. | ||
| void operator()(const TDouble1Vec& v, |
There was a problem hiding this comment.
Maybe document the parameters to this function too? i.e. v == overall variance and mean, n == overall count, vi == influencer variance and mean, etc.
tveasey
reviewed
Jul 11, 2018
docs/CHANGELOG.asciidoc
Outdated
| @@ -59,6 +59,7 @@ Age seasonal components in proportion to the fraction of values with which they' | |||
| Persist and restore was missing some of the trend model state ({pull}#99[#99]) | |||
| Stop zero variance data generating a log error in the forecast confidence interval calculation ({pull}#107[#107]) | |||
| Fix corner case failing to calculate lgamma values and the correspoinding log errors ({pull}#126[#126]) | |||
| Influence count per bucket was wrong and lead to wrong influencer scoring ({pull}#150[#150]) | |||
There was a problem hiding this comment.
On second thoughts, I'd say the "Influence count per bucket for metric population analyses was wrong..."
hendrikmuhs
pushed a commit
to hendrikmuhs/ml-cpp
that referenced
this pull request
Jul 11, 2018
Fix counting of influencer per bucket for metric population analyses, prior this fix the count has always been set to 1. Fixes elastic#24
hendrikmuhs
pushed a commit
that referenced
this pull request
Jul 12, 2018
Fix counting of influencer per bucket for metric population analyses, prior this fix the count has always been set to 1. Fixes #24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes counting of influencer per bucket, prior this fix the count has always been set to 1.
Notes:
testVarp) but test was forgotten to be added in the test suiteFixes #24
Release note: Fixes influence count per bucket for metric population analyses, which was
wrong and lead to incorrect influencer scoring