Move note to section about the type option #8604
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andrewvc On a related note, I'm not sure how the removal of types in ES affects the |
|
It's still valid because we are still compatible with ES 5.x.
Also, ES 6.0 does support types, just with the limitation of one type per
index
We should possibly warn when we detect types being used with ES6.
…On Nov 7, 2017 9:16 PM, "DeDe Morton" ***@***.***> wrote:
@andrewvc <https://github.com/andrewvc> On a related note, I'm not sure
how the removal of types in ES affects the type option for LS input
plugins. Will the option be deprecated, or still valid for 6.0?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#8604 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAIBY0hQNcLAzrvFNu1RgCLm_sOy7Ip7ks5s0RzxgaJpZM4QVwwv>
.
|
|
@dedemorton should we close this out? Is this change still something we want to do? |
|
Yes. For now, I'll just merge this PR to move the note. It basically moves the content to live under the |
elasticsearch-bot
pushed a commit
that referenced
this pull request
Nov 14, 2017
elasticsearch-bot
pushed a commit
that referenced
this pull request
Nov 14, 2017
|
(no need for approval because this PR simply moves existing content...doesn't add anything new). |
insukcho
pushed a commit
to insukcho/logstash
that referenced
this pull request
Feb 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes the note that was removed in logstash-plugins/logstash-input-beats#267 and moves it to the doc about the
typeoption. Now this content will appear in the correct place, but it's conditionally coded in the shared file so that it only shows up in the doc about the beats input plugin.Note that the statement will appear in two places until the plugin docs for 6.0 are re-published because I didn't get the change into the plugin branch in time for 6.0.