Backport PR #14018 to 7.17: Fix stopped pipeline unable to be deleted in registry #14033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Prior to the change, pipeline `stop` and `delete` happen in two converge cycles, which has a gap letting the stopped pipeline compare with the same pipeline definition in central pipeline management, hence Logstash see the stopped pipeline as graceful finish and not to delete in registry This commit creates StopAndDelete action to delete running pipeline in one converge cycle Fixed: #14017 (cherry picked from commit e8cd0d3)
kaisecheng
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport PR #14018 to 7.17 branch, original message:
Release notes
What does this PR do?
This commit makes the
stopanddeletepipeline action into a single action to make sure the running pipeline is deleted in registry if central pipeline management delete and recreate pipelines in short period of timeWhy is it important/What is the impact to the user?
Prior to this change, when the source (central pipeline management / kibana) delete a pipeline, the Logstash pipeline state transforms from stop to delete in two converge cycles. If the source recreates the same pipeline between the cycles, the stop pipeline cannot be deleted in registry because Logstash see them as graceful finish.
Checklist
Author's Checklist
How to test this PR locally
testpipelinetestpipeline in Kibana. Logstash will deletetestpipeline in the coming converge cycle. The log showtestin non_running_pipelinestestin Kibana with the same definitiontestin running_pipelines and thetestpipeline is runningRelated issues
Fixed: #14017
Relates: #12414
Use cases
Screenshots
Logs