-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc: Implement install widgets with platform tabs #12850
base: main
Are you sure you want to change the base?
Conversation
Status: 2021-0423Added test scenario under deb-x86_64 tab. (Test scenario must be backed out before this PR can be merged.) Next steps (notes to self @karenzone ):
|
@elasticmachine run elasticsearch-ci/docs |
1 similar comment
@elasticmachine run elasticsearch-ci/docs |
jenkins test this please |
@elasticmachine run elasticsearch-ci/docs |
@elasticmachine run elasticsearch-ci/docs |
@elasticmachine run elasticsearch-ci/docs |
@elasticmachine run elasticsearch-ci/docs |
@@ -0,0 +1,166 @@ | |||
// Defining styles and script here for simplicity. | |||
++++ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ToDo: Figure out which tab should be the default selection, and set it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need to include this anymore since as of elastic/docs#2180, this is included in the doc build itself and doesn't need to be in each repo that uses the tab widgets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOTED for future action. Thanks for the info. While I'm still developing content, it's handy to be able to fire off local builds for quickie testing.
I'll remove the file before I finalize this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds great, let me know if I can help at all.
Release notes
[rn:skip]
What does this PR do?
Adds tab widget infrastructure
Breaks up walls of text by adding tabbed widgets to show installation instructions per platform
PREVIEW: https://logstash_12850.docs-preview.app.elstc.co/guide/en/logstash/master/installing-logstash.html
Check out the DEB x86_64 tab for a sample of what both DEB platform install instructions might look like under one tab.
IMPORTANT: This work is still in the design/experimental phase, and install content is not accurate.
ToDO: