fix delete and recreate pipeline with same pipeline ID and config string #12389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
kaisecheng
force-pushed
the
delete-recreate-same-pipeline
branch
from
d7e41ea to
dd9aa67
Compare
andsel
reviewed
Oct 28, 2020
| if (this.metadata == null) { | ||
| synchronized(this) { | ||
| if (this.metadata == null) { | ||
| StringBuilder sb = confParts.stream().reduce(new StringBuilder(), (builder, item) -> builder.append(item.getMetadata()), StringBuilder::append); |
There was a problem hiding this comment.
Probably we could simplify with:
confParts.stream().map(SourceWithMetadata::getMetadata).collect( Collectors.joining(""));
kaisecheng
added a commit
to kaisecheng/logstash
that referenced
this pull request
Nov 9, 2020
add metadata in the hash function Fixed elastic#12387
kaisecheng
added a commit
to kaisecheng/logstash
that referenced
this pull request
Nov 9, 2020
add metadata in the hash function Fixed elastic#12387
kaisecheng
added a commit
to kaisecheng/logstash
that referenced
this pull request
Nov 11, 2020
add metadata in the hash function Fixed elastic#12387
elasticsearch-bot
pushed a commit
that referenced
this pull request
Nov 11, 2020
add metadata in the hash function Fixed #12387
kares
added a commit
that referenced
this pull request
Dec 1, 2020
andsel
pushed a commit
that referenced
this pull request
Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix the issue described in #12387 , this PR modifies the hash function of the pipeline to include metadata and config string.
Users should be able to recreate the pipeline given that the metadata value has changed.
A follow-up Kibana task should update the version number for every change