Simplify deleting spaces #99960
Merged
Simplify deleting spaces #99960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomheymann
added
release_note:enhancement
v8.0.0
v7.14.0
auto-backport
legrego
approved these changes
May 13, 2021
x-pack/plugins/spaces/public/management/spaces_management_app.tsx
Outdated
Show resolved
Hide resolved
| 'xpack.spaces.management.confirmDeleteModal.confirmButton', | ||
| { | ||
| defaultMessage: | ||
| '{isLoading, select, true{Deleting space and all contents…} other{Delete space and all contents}}', |
|
|
||
| import type { InjectedIntl } from '@kbn/i18n/react'; | ||
| import { FormattedMessage, injectI18n } from '@kbn/i18n/react'; | ||
| import { EuiCallOut, EuiConfirmModal, EuiSpacer, EuiText } from '@elastic/eui'; |
There was a problem hiding this comment.
Using the base EuiConfirmModal here makes me so happy. Thanks for taking the time to clean this up! It had a great side-effect of reducing our async chunk size too:
ryankeairns
approved these changes
May 14, 2021
Co-authored-by: Larry Gregory <[email protected]>
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsReferences to deprecated APIs
History
To update your PR or re-run it, just comment with: |
💔 Backport failed
To backport manually run: |
legrego
added
the
Team:Security
|
Pinging @elastic/kibana-security (Team:Security) |
thomheymann
added a commit
to thomheymann/kibana
that referenced
this pull request
May 18, 2021
* Simplify deleting spaces * Fixed i18n * Fix functional tests * Update x-pack/plugins/spaces/public/management/spaces_management_app.tsx Co-authored-by: Larry Gregory <[email protected]> * Fix snapshots Co-authored-by: Larry Gregory <[email protected]> Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # x-pack/plugins/spaces/public/management/spaces_management_app.tsx
thomheymann
added a commit
that referenced
this pull request
May 18, 2021
* Simplify deleting spaces * Fixed i18n * Fix functional tests * Update x-pack/plugins/spaces/public/management/spaces_management_app.tsx Co-authored-by: Larry Gregory <[email protected]> * Fix snapshots Co-authored-by: Larry Gregory <[email protected]> Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # x-pack/plugins/spaces/public/management/spaces_management_app.tsx
yctercero
pushed a commit
to yctercero/kibana
that referenced
this pull request
May 25, 2021
* Simplify deleting spaces * Fixed i18n * Fix functional tests * Update x-pack/plugins/spaces/public/management/spaces_management_app.tsx Co-authored-by: Larry Gregory <[email protected]> * Fix snapshots Co-authored-by: Larry Gregory <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #49856
Summary
This PR makes it easier to delete spaces by removing the requirement to type the name of the space in the confirmation modal. This caused issues when the space contained double spaces and was cumbersome for long space names. We already ask the user to confirm if they want to proceed which gives enough protection.
Deleting space confirmation modal
Edge case when deleting current space
Checklist
Delete any items that are not applicable to this PR.