Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Fix schema definition for job type #99954

Merged
merged 1 commit into from
May 12, 2021

Conversation

darnautov
Copy link
Contributor

Summary

Fixes request params schema definiton for /api/ml/saved_objects/can_delete_job endpoint to get a valid output for the ML Kibana API docs.
image

@darnautov darnautov added :ml v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels May 12, 2021
@darnautov darnautov requested a review from peteharverson May 12, 2021 16:17
@darnautov darnautov self-assigned this May 12, 2021
@darnautov darnautov requested a review from a team as a code owner May 12, 2021 16:17
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

References to deprecated APIs

id before after diff
crossClusterReplication 8 6 -2
monitoring 109 56 -53
total -55

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @darnautov

@darnautov darnautov merged commit cbdd1b2 into elastic:master May 12, 2021
@darnautov darnautov deleted the ml-fix-schema-definition branch May 12, 2021 22:02
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 12, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed :ml release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants