[kbn/test] move types/ftr into src #99555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elasticmachine merge upstream |
spalger
added
release_note:skip
|
Pinging @elastic/kibana-operations (Team:Operations) |
YulNaumenko
approved these changes
May 7, 2021
botelastic
bot
added
Team:APM
|
Pinging @elastic/apm-ui (Team:apm) |
|
Pinging @elastic/fleet (Team:Fleet) |
mshustov
approved these changes
May 7, 2021
dgieselaar
approved these changes
May 7, 2021
azasypkin
approved these changes
May 7, 2021
JasonStoltz
approved these changes
May 10, 2021
jbudz
approved these changes
May 10, 2021
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Unknown metric groupsReferences to deprecated APIs
History
To update your PR or re-run it, just comment with: |
spalger
added
the
auto-backport
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
May 17, 2021
* [kbn/test] move types/ftr into src * Apply eslint updates * fix import of Lifecycle type Co-authored-by: spalger <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
💔 Backport failed
Successful backport PRs will be merged automatically after passing CI. To backport manually run: |
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
May 17, 2021
* [kbn/test] move types/ftr into src * Apply eslint updates * fix import of Lifecycle type Co-authored-by: spalger <[email protected]> Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # x-pack/test/functional_cors/config.ts # x-pack/test/reporting_functional/reporting_and_deprecated_security.config.ts
kibanamachine
added a commit
that referenced
this pull request
May 17, 2021
* [kbn/test] move types/ftr into src * Apply eslint updates * fix import of Lifecycle type Co-authored-by: spalger <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Spencer <[email protected]> Co-authored-by: spalger <[email protected]>
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
kibanamachine
added
backport missing
spalger
pushed a commit
that referenced
this pull request
May 19, 2021
* [kbn/test] move types/ftr into src * Apply eslint updates * fix import of Lifecycle type Co-authored-by: spalger <[email protected]> Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # x-pack/test/functional_cors/config.ts # x-pack/test/reporting_functional/reporting_and_deprecated_security.config.ts Co-authored-by: Kibana Machine <[email protected]>
yctercero
pushed a commit
to yctercero/kibana
that referenced
this pull request
May 25, 2021
* [kbn/test] move types/ftr into src * Apply eslint updates * fix import of Lifecycle type Co-authored-by: spalger <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #99546
In order to support defining additional public ftr types we need to convert the
ftr.d.tsfile to be a concrete TS file, which means moving it into the src directory and rewriting all the imports for@kbn/test/types/ftrto@kbn/test. This PR focuses on that change with two commits, one with the functional changes and the other with all the import path updates which are all over the place and automatically applied and verified by eslint.