Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[App Search] Schema: Set up server routes, grand foray into shared/connected Kea logic #99548
[App Search] Schema: Set up server routes, grand foray into shared/connected Kea logic #99548
Changes from 1 commit
312128a
6cc7e18
e19ad5b
ff05b53
ccfc1fa
542e58f
3345322
0c60338
c12cdea
78c8f6d
82a711c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully comparing the two different logic files between source engines & meta engines helps illustrate why I chose to separate them - they're all in 1 file right now in the standalone UI and it's pretty hard to grok as a result. Hoping this is at least tidier.
It's honestly weird because the Meta Engine view, aside from the
schema
data, is almost completely different from the default/indexed schema view - it has no actual actions to take for example.Some day I'll have a breakthrough genius idea on how to better organize our meta engine vs indexed engine logic/views/etc., but that day is not today 🙃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how I didn't run into a type error with this before now, but without the
Partial<>
Typescript yells if you have just e.g.{ text: ['some-engine'], number: ['another-engine'] }
- it wants all the keys from SchemaType otherwise 🤷