Cleanup package.json resolutions. #99456

azasypkin · 2021-05-06T11:02:42Z

Summary

Cleanup/upgrade of the package.json resolutions where it was feasible.

azasypkin · 2021-05-06T13:22:28Z

package.json

@@ -324,7 +323,6 @@
    "react-ace": "^5.9.0",
    "react-beautiful-dnd": "^13.0.0",
    "react-color": "^2.13.8",
-    "react-datetime": "^2.14.0",


note: it's not used anywhere

package.json

azasypkin · 2021-05-06T13:23:32Z

package.json

    "**/chokidar": "^3.4.3",
-    "**/cross-fetch/node-fetch": "^2.6.1",


note: we don't have any package that depends on cross-fetch right now.

azasypkin · 2021-05-06T13:25:32Z

package.json

@@ -87,7 +86,7 @@
    "**/react-syntax-highlighter": "^15.3.1",
    "**/react-syntax-highlighter/**/highlight.js": "^10.4.1",
    "**/request": "^2.88.2",
-    "**/trim": "0.0.3",
+    "**/trim": "1.0.1",


note: really, nothing to worry about, just moved to a proper semver.

watson · 2021-05-06T15:21:58Z

yarn.lock

+"@types/node@*", "@types/[email protected]", "@types/[email protected]", "@types/[email protected]", "@types/node@>= 8", "@types/node@>=8.9.0", "@types/node@^10.1.0":
+  version "14.14.44"
+  resolved "https://registry.yarnpkg.com/@types/node/-/node-14.14.44.tgz#df7503e6002847b834371c004b372529f3f85215"
+  integrity sha512-+gaugz6Oce6ZInfI/tK4Pq5wIIkJMEJUu92RB3Eu93mtj4wjjjz9EB5mLp5s1pSsLXdC/CPut/xF20ZzAQJbTA==
+
+"@types/[email protected]":


These should probably be consolidated

package.json

watson · 2021-05-06T15:25:32Z

package.json

@@ -71,9 +71,8 @@
    "url": "https://github.com/elastic/kibana.git"
  },
  "resolutions": {
-    "**/@types/node": "14.14.14",
+    "**/@types/node": "14.14.44",


We should update our own reference in the package.json file as well

mshustov

ok for the Core changes

poffdeluxe · 2021-05-12T17:31:27Z

x-pack/plugins/canvas/shareable_runtime/components/canvas.tsx


-    timeout = setTimeout(
+    timeout = window.setTimeout(


what caused the need for this change?

That's because of NodeJS typings update that might have (finally) made setTimeout related types stricter. We don't yet clearly separate environments for TS compiler to know that this setTimeout is supposed to be provided by the browser and TS assumes that it's a NodeJS one. NodeJS setTimeout is a different API with a different return type (NodeJS.Timeout instead of number) than what browsers provide.

poffdeluxe

Presentation changes lgtm -- I tested out the shareable runtime and found no issues

azasypkin · 2021-05-19T18:51:34Z

@elasticmachine merge upstream

kibanamachine · 2021-05-19T20:39:50Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 3d94a85
Storybooks Preview
Pipeline Steps (look for red circles / failed steps)
Interpreting CI Failures

Failed CI Steps

Jest Integration Tests

Test Failures

Kibana Pipeline / general / Jest Integration Tests.src/core/server/saved_objects/migrationsv2/integration_tests.migration v2 rewrites id deterministically for SO with namespaceType: "multiple" and "multiple-isolated"

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 2 times on tracked branches: https://github.com/elastic/kibana/issues/98351

Stack Trace

: Timeout - Async callback was not invoked within the 280000 ms timeout specified by jest.setTimeout.Timeout - Async callback was not invoked within the 280000 ms timeout specified by jest.setTimeout.Error: 
    at new Spec (/dev/shm/workspace/parallel/3/kibana/node_modules/jest-jasmine2/build/jasmine/Spec.js:116:22)
    at new Spec (/dev/shm/workspace/parallel/3/kibana/node_modules/jest-jasmine2/build/setup_jest_globals.js:78:9)
    at specFactory (/dev/shm/workspace/parallel/3/kibana/node_modules/jest-jasmine2/build/jasmine/Env.js:523:24)
    at Env.it (/dev/shm/workspace/parallel/3/kibana/node_modules/jest-jasmine2/build/jasmine/Env.js:592:24)
    at Env.it (/dev/shm/workspace/parallel/3/kibana/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:134:23)
    at it (/dev/shm/workspace/parallel/3/kibana/node_modules/jest-jasmine2/build/jasmine/jasmineLight.js:100:21)
    at Suite.<anonymous> (/dev/shm/workspace/parallel/3/kibana/src/core/server/saved_objects/migrationsv2/integration_tests/rewriting_id.test.ts:110:3)
    at addSpecsToSuite (/dev/shm/workspace/parallel/3/kibana/node_modules/jest-jasmine2/build/jasmine/Env.js:444:51)
    at Env.describe (/dev/shm/workspace/parallel/3/kibana/node_modules/jest-jasmine2/build/jasmine/Env.js:414:11)
    at describe (/dev/shm/workspace/parallel/3/kibana/node_modules/jest-jasmine2/build/jasmine/jasmineLight.js:88:18)
    at Object.<anonymous> (/dev/shm/workspace/parallel/3/kibana/src/core/server/saved_objects/migrationsv2/integration_tests/rewriting_id.test.ts:91:1)
    at Runtime._execModule (/dev/shm/workspace/parallel/3/kibana/node_modules/jest-runtime/build/index.js:1299:24)
    at Runtime._loadModule (/dev/shm/workspace/parallel/3/kibana/node_modules/jest-runtime/build/index.js:898:12)
    at Runtime.requireModule (/dev/shm/workspace/parallel/3/kibana/node_modules/jest-runtime/build/index.js:746:10)
    at jasmine2 (/dev/shm/workspace/parallel/3/kibana/node_modules/jest-jasmine2/build/index.js:230:13)
    at runTestInternal (/dev/shm/workspace/parallel/3/kibana/node_modules/jest-runner/build/runTest.js:380:22)
    at runTest (/dev/shm/workspace/parallel/3/kibana/node_modules/jest-runner/build/runTest.js:472:34)

Metrics [docs]

Unknown metric groups

References to deprecated APIs

id	before	after	diff
`canvas`	29	25	-4
`crossClusterReplication`	8	6	-2
`fleet`	22	20	-2
`globalSearch`	4	2	-2
`indexManagement`	12	7	-5
`infra`	261	149	-112
`lens`	67	45	-22
`licensing`	18	15	-3
`maps`	286	208	-78
`ml`	121	115	-6
`monitoring`	109	56	-53
`stackAlerts`	101	95	-6
total			-295

History

💚 Build #126616 succeeded 1da67ea
💛 Build #126336 was flaky 60fef9c
💛 Build #125974 was flaky 68d6c14
💚 Build #124965 succeeded 2028a99

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine · 2021-05-19T20:42:13Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

Co-authored-by: Aleh Zasypkin <[email protected]>

Cleanup package.json resolutions.

b17423e

azasypkin added chore release_note:skip Skip the PR/issue when compiling release notes v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels May 6, 2021

azasypkin commented May 6, 2021

View reviewed changes

package.json Show resolved Hide resolved

azasypkin commented May 6, 2021

View reviewed changes

azasypkin marked this pull request as ready for review May 6, 2021 13:26

azasypkin requested a review from a team as a code owner May 6, 2021 13:26

azasypkin requested a review from a team May 6, 2021 13:26

patrykkopycinski approved these changes May 6, 2021

View reviewed changes

watson suggested changes May 6, 2021

View reviewed changes

azasypkin added 3 commits May 6, 2021 17:30

Merge branch 'master' into issue-xxx-update-resolutions

19f8cce

Review#1: handle feedback.

90dfa8f

Adjust stat and setTimeout return types.

bc972b9

azasypkin requested review from a team as code owners May 6, 2021 16:42

mshustov approved these changes May 6, 2021

View reviewed changes

azasypkin added 2 commits May 10, 2021 08:22

Merge branch 'master' into issue-xxx-update-resolutions

7047f0d

Resolve conflicts with master.

2028a99

azasypkin requested a review from watson May 10, 2021 10:02

poffdeluxe reviewed May 12, 2021

View reviewed changes

Merge branch 'master' into issue-xxx-update-resolutions

68d6c14

azasypkin requested a review from poffdeluxe May 17, 2021 07:24

watson approved these changes May 18, 2021

View reviewed changes

Merge branch 'master' into issue-xxx-update-resolutions

60fef9c

poffdeluxe approved these changes May 19, 2021

View reviewed changes

Merge branch 'master' into issue-xxx-update-resolutions

3d94a85

azasypkin enabled auto-merge (squash) May 19, 2021 18:20

Merge branch 'master' into issue-xxx-update-resolutions

1da67ea

azasypkin merged commit c6e8ee2 into elastic:master May 19, 2021

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 19, 2021

Cleanup package.json resolutions. (elastic#99456)

2216bdd

kibanamachine mentioned this pull request May 19, 2021

[7.x] Cleanup package.json resolutions. (#99456) #100365

Merged

kibanamachine added a commit that referenced this pull request May 19, 2021

Cleanup package.json resolutions. (#99456) (#100365)

71fd3a7

Co-authored-by: Aleh Zasypkin <[email protected]>

azasypkin deleted the issue-xxx-update-resolutions branch May 20, 2021 05:54

yctercero pushed a commit to yctercero/kibana that referenced this pull request May 25, 2021

Cleanup package.json resolutions. (elastic#99456)

e6e06c5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cleanup package.json resolutions. #99456

Cleanup package.json resolutions. #99456

azasypkin commented May 6, 2021 •

edited

Loading

azasypkin May 6, 2021

azasypkin May 6, 2021

azasypkin May 6, 2021

watson May 6, 2021

watson May 6, 2021

mshustov left a comment

poffdeluxe May 12, 2021

azasypkin May 14, 2021

poffdeluxe left a comment

azasypkin commented May 19, 2021

kibanamachine commented May 19, 2021 •

edited

Loading

Standard Out

Stack Trace

References to deprecated APIs

kibanamachine commented May 19, 2021

		"**/chokidar": "^3.4.3",
		"**/cross-fetch/node-fetch": "^2.6.1",

Cleanup package.json resolutions. #99456

Cleanup package.json resolutions. #99456

Conversation

azasypkin commented May 6, 2021 • edited Loading

Summary

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mshustov left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

poffdeluxe left a comment

Choose a reason for hiding this comment

azasypkin commented May 19, 2021

kibanamachine commented May 19, 2021 • edited Loading

💔 Build Failed

Failed CI Steps

Standard Out

Stack Trace

Metrics [docs]

References to deprecated APIs

History

kibanamachine commented May 19, 2021

💚 Backport successful

azasypkin commented May 6, 2021 •

edited

Loading

kibanamachine commented May 19, 2021 •

edited

Loading