Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove joi usage from x-pack #99401

Merged
merged 3 commits into from
May 11, 2021
Merged

remove joi usage from x-pack #99401

merged 3 commits into from
May 11, 2021

Conversation

mshustov
Copy link
Contributor

@mshustov mshustov commented May 5, 2021 •
edited
Loading

Summary

  • APM. I haven't found any usages of the utility
  • Security Solutions might use a custom type instead

@mshustov mshustov added chore Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v8.0.0 v7.14.0 labels May 5, 2021
@mshustov mshustov changed the title [APM] remove unused helper remove joi usage from x-pack May 5, 2021
@mshustov mshustov added the release_note:skip Skip the PR/issue when compiling release notes label May 5, 2021
@mshustov mshustov marked this pull request as ready for review May 6, 2021 08:19
@mshustov mshustov requested review from a team as code owners May 6, 2021 08:19
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@mshustov
Copy link
Contributor Author

@elasticmachine merge upstream

@mshustov mshustov enabled auto-merge (squash) May 10, 2021 18:52
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

References to deprecated APIs

id before after diff
canvas 29 25 -4
crossClusterReplication 8 6 -2
fleet 4 2 -2
globalSearch 4 2 -2
indexManagement 12 7 -5
infra 5 3 -2
licensing 18 15 -3
monitoring 109 56 -53
total -73

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mshustov mshustov merged commit d1d741b into elastic:master May 11, 2021
@mshustov mshustov deleted the apm-remove-joi branch May 11, 2021 08:18
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 13, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 99401 or prevent reminders by adding the backport:skip label.

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 99401 or prevent reminders by adding the backport:skip label.

@mshustov mshustov mentioned this pull request May 14, 2021
Merged
mshustov added a commit to mshustov/kibana that referenced this pull request May 14, 2021
@mshustov @kibanamachine
remove joi usage from x-pack (elastic#99401)
27aea5d 
* remove unused helper

* remove joi usage from Security Solutions

Co-authored-by: Kibana Machine <[email protected]>
mshustov added a commit that referenced this pull request May 14, 2021
@mshustov @kibanamachine
remove joi usage from x-pack (#99401) (#100110)
defeb5e 
* remove unused helper

* remove joi usage from Security Solutions

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgieselaar dgieselaar dgieselaar approved these changes

@banderror banderror banderror approved these changes

Assignees
No one assigned
Labels
chore release_note:skip Skip the PR/issue when compiling release notes Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mshustov @elasticmachine @kibanamachine @dgieselaar @banderror