Fix flaky bsearch test #99277
Merged
Fix flaky bsearch test #99277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasolson
added
review
Feature:Search
|
Pinging @elastic/kibana-app-services (Team:AppServices) |
Dosant
reviewed
May 5, 2021
There was a problem hiding this comment.
There is one more place we check:
kibana/test/api_integration/apis/search/bsearch.ts
Lines 86 to 87 in 9762065
Should we update that also?
btw, here is the failure: #98098
Also curious if we'd rather added logic to refetch until completed (similar to our polling inside Kibana), but I think this is not for this pr.
Dosant
approved these changes
May 5, 2021
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @lukasolson |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 6, 2021
* Fix flaky bsearch test * Review feedback
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
May 7, 2021
* Fix flaky bsearch test * Review feedback Co-authored-by: Lukas Olson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #98245.
As @Dosant pointed out in #98245 (comment), this test started being flaky when we switched the default to async search, since it can possibly return partial responses. This PR updates the test to check that the property exists rather than checking the value itself.
Checklist
For maintainers