-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM][RUM] adjust data types for uiFilters and range in APM requests #99257
[APM][RUM] adjust data types for uiFilters and range in APM requests #99257
Conversation
Pinging @elastic/apm-ui (Team:apm) |
Pinging @elastic/uptime (Team:uptime) |
@elasticmachine merge upstream |
…-adjust-data-types-for-has-rum-data-api-call
…ll' of https://github.com/dominiqueclarke/kibana into fix/56-uptime-adjust-data-types-for-has-rum-data-api-call
2138cfa
to
0d334c8
Compare
8df7d80
to
9eed989
Compare
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ll' of https://github.com/dominiqueclarke/kibana into fix/56-uptime-adjust-data-types-for-has-rum-data-api-call
💚 Build SucceededMetrics [docs]Unknown metric groupsReferences to deprecated APIs
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…lastic#99257) * update has_rum_data api query types Co-authored-by: Kibana Machine <[email protected]>
…lastic#99257) * update has_rum_data api query types Co-authored-by: Kibana Machine <[email protected]>
…99257) (#100152) * update has_rum_data api query types Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Dominique Clarke <[email protected]>
…99257) (#100151) * update has_rum_data api query types Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Dominique Clarke <[email protected]>
…lastic#99257) * update has_rum_data api query types Co-authored-by: Kibana Machine <[email protected]>
Summary
Fixes elastic/uptime-dev#56
This PR adjusts data type for the query in has_rum_data route.
This is primarily to resolve issues with the hasRumData route, the params for which can be entirely undefined.
In particular, the exploratory view uses this api route to dynamically fetch apm indicies, without passing any params. This caused the error
Invalid value undefined supplied to : strict_keys/0: Partial<{ query: ({ uiFilters: string } & { start: isoToEpochRt, end: isoToEpochRt }) }>/query: ({ uiFilters: string } & { start: isoToEpochRt, end: isoToEpochRt })/0: { uiFilters: string }/uiFilters: string
when debug settings were applied.To test
For APM exploratory view data, it's best to point your local kibana to edge ES.
In the advanced settings, turn Observability debug on
Navigate to exploratory view using the "Analyze Data" button in User Experience or Uptime
Select the data type as "User Experience (RUM)".
Ensure that the two report types "KPI over time" and "Performance Distribution" appear, and that there are no errors from api calls in the network tab.
This API is also used by the Observability Overview page UX section. We should also smoke test that section to make sure it's still working.
[ ] Observability Overview UX page is still working in both debug and regular mode
[ ] Exploratory View "User Experience (RUM)" data type works in both debug and regular mode