Fail jenkins build unless ci-stats reports success #98846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
Team:Operations
spalger
force-pushed
the
fix/ci-stats-reporting
branch
from
8f8233f to
822f1b4
Compare
spalger
added
release_note:skip
|
Pinging @elastic/kibana-operations (Team:Operations) |
brianseeders
approved these changes
Apr 30, 2021
|
@elasticmachine merge upstream Looks like the build from when master was merged but this PR was momentarily still based on 7.13 just finished, and the "mergeBase" was from 2019 when we forked 7.x. Reminder to myself: need to make sure ci-stats is returning |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
jbudz
approved these changes
Apr 30, 2021
spalger
added
the
auto-backport
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 30, 2021
Co-authored-by: spalger <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 30, 2021
Co-authored-by: spalger <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Apr 30, 2021
Co-authored-by: spalger <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Spencer <[email protected]> Co-authored-by: spalger <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Apr 30, 2021
Co-authored-by: spalger <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Spencer <[email protected]> Co-authored-by: spalger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI Stats has been writing the status of metrics to Kibana PRs for a while, which keeps people from merging those PRs, but it doesn't fail the actual Jenkins job which is confusing, and has lead to auto-merging allowing PRs with failed metrics (only been a problem on one backport so far).
This fixes the problem by adding a check to the Jenkins pipeline, not just when creating the comment but as a step in the pipeline that fails when ci-stats is not reporting a success (this might be because metrics are over a limit, or because of some other failure in the ci-stats service).