-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Add sudo to fleet managed instructions #98803
[Fleet] Add sudo to fleet managed instructions #98803
Conversation
Pinging @elastic/fleet (Team:Fleet) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't call this out very well in the original issue (my bad, sorry!), but I would also like to match this UI with the Fleet Server one, meaning: a dropdown list to select the platform and have the commands change based on that. Do you think it would be possible to get that in? You can leave out RPM/DEB (keep the current link to docs for those).
@jen-huang I just updated the PR to add the platform selection |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the dropdown changes, this was a big UI annoyance that we've had for a while :) Tested locally, LGTM 🚀
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: cc @nchaulet |
Co-authored-by: Nicolas Chaulet <[email protected]>
Co-authored-by: Nicolas Chaulet <[email protected]>
Summary
Resolve #88994
Add sudo to mac/linux instruction to add an agent, so we are consistent with the add a fleet server instructions
Note: I did not update the standalone instructions as these instructions are not per platform.
UI Change
By default it's the mac/linux one that is selected