Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Add sudo to fleet managed instructions #98803

Merged

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Apr 29, 2021

Summary

Resolve #88994

Add sudo to mac/linux instruction to add an agent, so we are consistent with the add a fleet server instructions

Note: I did not update the standalone instructions as these instructions are not per platform.

UI Change

By default it's the mac/linux one that is selected

Screen Shot 2021-04-29 at 2 35 58 PM

Screen Shot 2021-04-29 at 2 35 52 PM

Screen Shot 2021-04-29 at 2 35 46 PM

@nchaulet nchaulet added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.14.0 v7.13.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Apr 29, 2021
@nchaulet nchaulet self-assigned this Apr 29, 2021
@nchaulet nchaulet requested a review from a team as a code owner April 29, 2021 17:53
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@nchaulet nchaulet enabled auto-merge (squash) April 29, 2021 17:53
Copy link
Contributor

@jen-huang jen-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't call this out very well in the original issue (my bad, sorry!), but I would also like to match this UI with the Fleet Server one, meaning: a dropdown list to select the platform and have the commands change based on that. Do you think it would be possible to get that in? You can leave out RPM/DEB (keep the current link to docs for those).

@nchaulet
Copy link
Member Author

@jen-huang I just updated the PR to add the platform selection

Copy link
Contributor

@jen-huang jen-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the dropdown changes, this was a big UI annoyance that we've had for a while :) Tested locally, LGTM 🚀

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
fleet 454 455 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 724.5KB 724.4KB -153.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.13
7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Apr 29, 2021
kibanamachine added a commit that referenced this pull request Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.13.0 v7.14.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet] Add "sudo" to Elastic Agent enrollment commands
4 participants